Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit transparent colors as rgba(0, 0, 0, 0) #2298

Closed
xzyfer opened this issue Jan 14, 2017 · 4 comments
Closed

Emit transparent colors as rgba(0, 0, 0, 0) #2298

xzyfer opened this issue Jan 14, 2017 · 4 comments

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Jan 14, 2017

[..] we've decided to officially drop support for versions of IE prior to IE9, which was the first to support rgba(). As such, we'll start emitting all colors with no alpha component as rgba(0, 0, 0, 0) across the board.

Sass issue: sass/sass#1782

This is a significant BC break so this should be the last thing to land before tagging 3.5 stable. This way implementors can make releases with the CSS compat stuff in 3.5 without breaking their BC.

@xzyfer
Copy link
Contributor Author

xzyfer commented Jan 28, 2017

  • if the user authored transparent is should be preserved in the output.
  • if a color ends up with a 0 alpha channel at output time, output it as rbga(r, g, b, 0)

@mgreter
Copy link
Contributor

mgreter commented Jan 11, 2018

@nex3 @chriseppstein @xzyfer can somebody come up with some comprehensive spec tests? I think implementing it should be pretty trivial. Thanks!

@nex3
Copy link
Contributor

nex3 commented Jan 12, 2018

@mgreter The spec changes in sass/sass-spec@4e9edaa should encompass these changes.

@xzyfer
Copy link
Contributor Author

xzyfer commented Jan 12, 2018 via email

@xzyfer xzyfer removed the BLOCKED label Mar 28, 2018
xzyfer added a commit to xzyfer/libsass that referenced this issue Mar 28, 2018
This change breaks browser compat for IE < 10 so it is scheduled
for 3.6. It will not be back ported to the 3.5 line.

See sass/sass#1782
Fixes sass#2298
Spec sass/sass-spec#1242
@xzyfer xzyfer removed this from the 3.5 milestone Mar 28, 2018
xzyfer added a commit that referenced this issue Mar 28, 2018
This change breaks browser compat for IE < 10 so it is scheduled
for 3.6. It will not be back ported to the 3.5 line.

See sass/sass#1782
Fixes #2298
Spec sass/sass-spec#1242
xzyfer added a commit that referenced this issue Mar 30, 2018
This change breaks browser compat for IE < 10 so it is scheduled
for 3.6. It will not be back ported to the 3.5 line.

See sass/sass#1782
Fixes #2298
Spec sass/sass-spec#1242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants