Implement rounding precision

[mgreter]

Should pass sass/sass-spec#696

Update rounding behavior for upcoming ruby sass 3.4.20.

My implementation should return the same results but avoids the fmod division operation.
We may also want to calculate the epsilon only once at startup and store it in options.

[xzyfer]

Let's leave this until sass spec is 3.4.20/ready. I assume there's a test
case for this new behaviour?
On 7 Nov 2015 12:03 am, "Marcel Greter" [email protected] wrote:

Update rounding behavior for upcoming ruby sass 3.4.20
sass/sass#1883.

My implementation should return the same results but avoids the fmod
division operation.
We may also want to calculate the epsilon only once at startup and store

it in options.

You can view, comment on, or merge this pull request online at:

#1704
Commit Summary

• Fix static value parsing for numbers with units
• Implement precision for Sass::round function

File Changes

• M src/ast.cpp
  https:/sass/libsass/pull/1704/files#diff-0 (12)
• M src/functions.cpp
  https:/sass/libsass/pull/1704/files#diff-1 (16)
• M src/prelexer.cpp
  https:/sass/libsass/pull/1704/files#diff-2 (2)
• M src/util.cpp
  https:/sass/libsass/pull/1704/files#diff-3 (17)
• M src/util.hpp
  https:/sass/libsass/pull/1704/files#diff-4 (2)

Patch Links:

• https:/sass/libsass/pull/1704.patch
• https:/sass/libsass/pull/1704.diff

—
Reply to this email directly or view it on GitHub
#1704.

[mgreter]

As confirmed by ruby sass dev team, this was a bug. Not sure why we should withold a bugfix that doesn't affect our spec tests! We have a lot of other edges that are not 100% compatible with ruby sass output. It does not break existing spec tests, so for me this is ready to be merged!
As for the tests, we currently don't support tests with custom (precision) options!

[saper]

Is precision a user-defined option in ruby sass as well?

[mgreter]

Yes it is.