Add crutch to help browsers interpreting sourcemaps #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should report where the scope gets opened and not the position of the first simple selector in the sequence.
|
👍 |
xzyfer
added a commit
that referenced
this pull request
Nov 28, 2015
Add crutch to help browsers interpreting sourcemaps
|
@mgreter I understand the kludge is still in effect? It may be that it's not needed anymore. I didn't test it thoroughly, but from my couple of attempts it seems like at least Chromium 63 looks for the next mapping after the opening curly bracket. And there's a related issue, where a guy from Firefox team wants to change libsass behavior. But it may be an opportunity to change how Firefox handles things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They should report where the scope gets opened and not
the position of the first simple selector in the sequence.
Browsers actually report the mapping found most right just before the first selector in the sequence. I first tried to simply wrap each entry in a selector list with a mapping from their last complex selector, but as it turned out browsers wouldn't pick that up, so I had to delay the emmitting of that specific source map entry just before the token for the selector is emitted.
Should fix #1747