Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: Add exit code for explicit test #1810

Merged
merged 1 commit into from
Dec 29, 2015
Merged

Conversation

am11
Copy link
Contributor

@am11 am11 commented Dec 28, 2015

Also fixes regression form #1774:

In #1774, I switched ExpandEnvironmentVariables to $env, which
breaks the subsequent empty string checks.
$env:APPVEYOR_PULL_REQUEST_NUMBER, returns NULL, when commit is not
yet associated with PR.

This PR adds null or empty check along with
minor improvement for Get-Content (instead of .NET IO).

@am11 am11 force-pushed the node-sass/716 branch 6 times, most recently from 29b5786 to 8bdc513 Compare December 28, 2015 17:55
Also fixes regression form sass#1774:

In sass#1774, I switched `ExpandEnvironmentVariables` to `$env`, which
breaks the subsequent empty string checks.
`$env:APPVEYOR_PULL_REQUEST_NUMBER`, returns `NULL`, when commit is not
yet associated with PR.

This PR adds null or empty check along with
minor improvement for `Get-Content` (instead of .NET IO).
@xzyfer
Copy link
Contributor

xzyfer commented Dec 29, 2015

I'll take your word for it :)

xzyfer added a commit that referenced this pull request Dec 29, 2015
Add exit code for AppVeyor explicit test
@xzyfer xzyfer merged commit a508a7c into sass:master Dec 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants