Fix join_paths when left path is not canonical
#1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We blindly count `/./` as an actual directory, thus the results were wrong when the right side starts with `../`.
|
Is this related to #1750? If not do you think you can look into it? Feels like it might be a regression in the recent context refactor. |
|
Hmm, could be, but no real way to test it with libsass. Saw it from a perl-libsass integration test ... |
|
BTW. bug in |
|
Interesting. Ship when ready. |
|
Waiting for 🚥 |
mgreter
added a commit
that referenced
this pull request
Jan 6, 2016
Fix `join_paths` when left path is not canonical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We blindly count
/./as an actual directory, thus theresults were wrong when the right side starts with
../.