Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SmartOS compilation once and for all #1847

Merged
merged 5 commits into from
Jan 12, 2016
Merged

Fix SmartOS compilation once and for all #1847

merged 5 commits into from
Jan 12, 2016

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Jan 10, 2016

Verified by compiling inside VMWare image (the problems with SEC were present):

SunOS smartos 5.11 joyent_20160108T173524Z i86pc i386 i86pc

Let's see what CI thinks ... #1802

@mgreter mgreter mentioned this pull request Jan 10, 2016
Closed
@mgreter
Copy link
Contributor Author

mgreter commented Jan 11, 2016

The last commit reverts the SunOS specifics in the Makefile:

1) We need to have libtool installed and ginstall is not available by default too!
2) We install to / on all platforms (use PREFIX="/opt/local" make to override).

SmartOS needs: pkgin install automake autoconf libtool!
Then we can also build libsass via autotools as documented.

@mgreter mgreter changed the title Fix smartos compilation once and for all Fix SmartOS compilation once and for all Jan 11, 2016
@mgreter mgreter force-pushed the bugfix/smartos-compilation branch 2 times, most recently from 2f0d5f0 to 687a969 Compare January 11, 2016 00:23
@xzyfer
Copy link
Contributor

xzyfer commented Jan 11, 2016

@jaredmorrow @djensen47 I'd like to hear your thoughts here

@mgreter
Copy link
Contributor Author

mgreter commented Jan 11, 2016

Looks like ginstall would still be the correct one to use. libtool install doesn't seem to do the right thing, was asuming it would. But no idea how to get gnu-install on to SmartOS. Maybe if someone can argue why we cannot install into / on Solaris, please enlighten me.

Btw. install from libtools outputs:

find: cycle detected for /lib/crypto/32/
find: cycle detected for /lib/secure/32/
find: cycle detected for /lib/32/
find: cycle detected for /usr/lib/elfedit/32/
find: cycle detected for /usr/lib/libp/32/
find: cycle detected for /usr/lib/link_audit/32/
find: cycle detected for /usr/lib/lwp/32/
find: cycle detected for /usr/lib/secure/32/
find: cycle detected for /usr/lib/32/
install: libsass.a was not found anywhere!

¯_(ツ)_/¯

@mgreter mgreter force-pushed the bugfix/smartos-compilation branch 2 times, most recently from 2c6a78f to 19d9b71 Compare January 11, 2016 02:14
@mgreter mgreter self-assigned this Jan 11, 2016
@mgreter mgreter added this to the 3.3.3 milestone Jan 11, 2016
@mgreter
Copy link
Contributor Author

mgreter commented Jan 11, 2016

Verfied both install methods and documented my findings. Very very sure this chapter can be closed!

@mgreter
Copy link
Contributor Author

mgreter commented Jan 12, 2016

I'm going to merge this on my responsibility. Beside CI I have tested it with Visual Studio 2013 Community, SmartOS 5.11, Gentoo Linux, Cygwin and MinGW. Not all combinations, but a fair share.
Want to move forward and concentrate to bring sass 3.4.21 parity!
As always feel free to open issues when problems arise.
Have a nice day!

mgreter added a commit that referenced this pull request Jan 12, 2016
@mgreter
Merge pull request #1847 from mgreter/bugfix/smartos-compilation
c9f5a49 
Fix SmartOS compilation once and for all
@mgreter mgreter merged commit c9f5a49 into sass:master Jan 12, 2016
@mgreter mgreter mentioned this pull request Jan 13, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mgreter mgreter

Labels
Dev - PR Ready
Projects
None yet
Milestone
3.3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@mgreter @xzyfer