Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error if cwd goes missing #2529

Merged
merged 1 commit into from
Jan 11, 2018
Merged

Throw error if cwd goes missing #2529

merged 1 commit into from
Jan 11, 2018

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Jan 11, 2018 •
edited
Loading

Addresses #2513. Did not test windows implementation, but I trust our CI ;)

@mgreter mgreter self-assigned this Jan 11, 2018
@mgreter mgreter merged commit ebc1f49 into sass:master Jan 11, 2018
@mgreter mgreter mentioned this pull request Jan 11, 2018
Closed
@asottile
Copy link
Member

sweet thanks!

@mgreter
Copy link
Contributor Author

mgreter commented Jan 11, 2018

You're welcome. Btw. thanks for your nice python integration and constant good bug reports!
LibSass could probably handle this error more gracefully, but I think a hard error is ok in this case 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mgreter mgreter

Labels
Back port to 3.4 stable Dev - PR Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgreter @asottile