Add and use our own ASCII case-conversion routines #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
force-pushed
the
ascii
branch
3 times, most recently
from
692251b
to
ac3bfd9
Compare
|
sass2scss is an external library we vender in. The upstream is mgreter/sass2scss |
glebm
force-pushed
the
ascii
branch
2 times, most recently
from
82d39fe
to
9894790
Compare
|
Ah, thanks. Removed the sass2scss commit and opened mgreter/sass2scss#39 instead. |
|
Note that we don't vendor master atm. There was a regression and we had to
revert to an older commit a while back. Pulling in the lastest upstream may
not be trivial.
…On Sun., 16 Jun. 2019, 8:40 am Gleb Mazovetskiy, ***@***.***> wrote:
Ah, thanks. Removed the sass2scss commit and opened mgreter/sass2scss#39
<mgreter/sass2scss#39> instead.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2911?email_source=notifications&email_token=AAENSWGDH33MU43EFTAQVH3P2XN4LA5CNFSM4HYQNL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXZGQWQ#issuecomment-502425690>,
or mute the thread
<https:/notifications/unsubscribe-auth/AAENSWECQG5GDNDLNQN5VJTP2XN4LANCNFSM4HYQNL5A>
.
|
mgreter
reviewed
Jun 16, 2019
glebm
force-pushed
the
ascii
branch
2 times, most recently
from
7e549c7
to
f99a92a
Compare
`std::tolower` and `std::toupper` are locale-dependent and should not be used anywhere we currently use them. Adds and switches to our own implementations for these and other locale-dependent functions.
Also removes "unicode" and replaces "nonascii". They were identical in behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::tolowerandstd::toupperare locale-dependent and should not be used anywhere we currently use them.Adds and switches to our own implementations for these and other locale-dependent functions.