Fix bug in scale-color with positive saturation #2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ternary operator incorrectly selected the luminance value when it should have used the saturation. With this fix, the returned values are as expected per the issue. Fixes sass#2903.
|
Thanks! Might need to enable something in sass-spec as well if there is a disabled test for this |
|
I didn't find a test so I'm looking to add one. |
zwass
added a commit
to zwass/sass-spec
that referenced
this pull request
Jul 23, 2019
These tests are fixed by sass/libsass#2954
|
Oh wait I did find some disabled tests and put up a PR to enable them: sass/sass-spec#1447 |
|
Just closing/opening to try and retrigger the sass-spec test using the PR text magic :) |
|
Thanks |
xzyfer
pushed a commit
to sass/sass-spec
that referenced
this pull request
Jul 23, 2019
These tests are fixed by sass/libsass#2954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ternary operator incorrectly selected the luminance value when it
should have used the saturation. With this fix, the returned values are
as expected per the issue.
See sass/sass-spec#1447
Fixes #2903.