Fix extend edge case going endlessly #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly avoiding to add duplicate selectors already seems to improve the situation heavily. Also added a hard-limit of 500 selectors to create at maximum. Hoping nobody needs more.
mgreter
force-pushed
the
feature/harden-endless-extend
branch
from
f18a6c3
to
8f1a5d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly avoiding to add duplicate selectors already seems
to improve the situation heavily. Also added a hard-limit of
500 selectors to create at maximum. Hoping nobody needs more.
To bad I didn't see/find this fix one year ago when the issue was introduced.
The change should IMHO be sane and I hope it doesn't break anything.
Addresses #3081