Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around C++11 nullptr #996

Closed
wants to merge 1 commit into from
Closed

Work around C++11 nullptr #996

wants to merge 1 commit into from

Conversation

saper
Copy link
Member

@saper saper commented Mar 28, 2015

Provide CXX11_NULLPTR autoconf macro

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.4% when pulling 9669f7d on saper:nullptr into 091010d on sass:master.

@mgreter mgreter added the Build label Mar 28, 2015
@saper saper mentioned this pull request Apr 23, 2015
Closed
@xzyfer
Copy link
Contributor

xzyfer commented Jul 27, 2015

@saper is this still relevant? If so please rebase off master.

@xzyfer
Copy link
Contributor

xzyfer commented Aug 11, 2015

Ping ^

@saper saper mentioned this pull request Aug 22, 2015
Closed
@saper
Work around C++11 nullptr
55d3a4c 
Provide CXX11_NULLPTR autoconf macro
@saper
Copy link
Member Author

saper commented Sep 17, 2015

Rebased for @drewwells for experiments with limited compiler environment (Android, MacOS X 10.6 SDK, etc.)

@saper saper mentioned this pull request Oct 25, 2015
Open
@mgreter
Copy link
Contributor

mgreter commented Oct 27, 2015

IMO it's easier to just replace nullptr with 0, I see no real need for it, we use 0 all over the place.

@xzyfer
Copy link
Contributor

xzyfer commented Oct 27, 2015

I think agree with @mgreter. We don't have the issues nullptr is intended to fix.

@saper
Copy link
Member Author

saper commented Oct 27, 2015 via email

@xzyfer xzyfer mentioned this pull request Oct 28, 2015
Closed
@xzyfer
Copy link
Contributor

xzyfer commented Oct 28, 2015

Tracking in #1657

@xzyfer xzyfer closed this Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build Dev - Internal Dev - Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saper @coveralls @xzyfer @mgreter