Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Commit

Permalink
Merge pull request #872 from xzyfer/release/3.0.0-beta.6
Browse files Browse the repository at this point in the history
Release 3.0.0 beta.6
  • Loading branch information
xzyfer committed Apr 21, 2015
2 parents 0e7278b + a34d3ce commit ea3430e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "node-sass",
"version": "3.0.0-beta.5",
"libsass": "3.2.0-beta.5",
"version": "3.0.0-beta.6",
"libsass": "3.2.0-beta.6",
"description": "Wrapper around libsass",
"license": "MIT",
"homepage": "https:/sass/node-sass",
Expand Down
2 changes: 1 addition & 1 deletion src/libsass
Submodule libsass updated 21 files
+2 −0 .travis.yml
+9 −3 Makefile
+1 −0 Readme.md
+9 −0 ast.cpp
+50 −4 ast.hpp
+2 −2 backtrace.hpp
+1 −1 constants.cpp
+195 −69 debugger.hpp
+2 −6 environment.hpp
+50 −10 eval.cpp
+47 −10 expand.cpp
+14 −5 functions.cpp
+132 −135 json.cpp
+25 −10 lexer.hpp
+19 −17 parser.cpp
+9 −3 parser.hpp
+1 −0 position.hpp
+19 −14 prelexer.cpp
+3 −3 script/ci-build-libsass
+24 −1 util.cpp
+4 −0 util.hpp
2 changes: 1 addition & 1 deletion test/fixtures/spec
Submodule spec updated 136 files

4 comments on commit ea3430e

@olsonpm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finished tracking a bug: I believe this revision change is breaking my deployment to heroku due to the release download not yet being available. Am I incorrect?

The url heroku tried downloading:

https:/sass/node-sass/releases/download/v3.0.0-beta.6/linux-x64-14_binding.node

The url I found manually via browsing the releases page:

https:/sass/node-sass/releases/download/v3.0.0-beta.5/linux-x64-14_binding.node

The only difference is ...beta.5/linux... vs ...beta.6/linux...

@xzyfer
Copy link
Contributor Author

@xzyfer xzyfer commented on ea3430e Apr 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious. How are you installing node-sass? There is no 3.0.0-beta.6 tag yet so you should not be getting this changes unless you're installing from git.

@olsonpm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, I was unaware of how releases were handled. I needed v3 and was referencing master directly hence the error.

I will raise an issue next time too, instead of commenting on the commit directly.

Thanks for the quick response.

@xzyfer
Copy link
Contributor Author

@xzyfer xzyfer commented on ea3430e Apr 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right that'll always end in pain. I suggest npm install node-sass@beta for now 😄

Please sign in to comment.