Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Build: Uses v8 version instead of runtime name. #695

Merged
merged 1 commit into from
Feb 23, 2015
Merged

Conversation

am11
Copy link
Contributor

@am11 am11 commented Feb 22, 2015

The new binary path format is:
<platform>-<arch>-<v8 version>/binding.node

Issue URL: #694.

The new binary path format is:
`<platform>-<arch>-<v8 version>/binding.node`

Issue URL: sass#694.
PR URL: sass#695.
@xzyfer
Copy link
Contributor

xzyfer commented Feb 22, 2015

👍

@am11 am11 force-pushed the master branch 2 times, most recently from d59e01f to 19b5e3c Compare February 23, 2015 21:55
am11 added a commit that referenced this pull request Feb 23, 2015
Build: Uses v8 version instead of runtime name.
@am11 am11 merged commit 9245668 into sass:master Feb 23, 2015
@xzyfer xzyfer mentioned this pull request Feb 26, 2015
@saper
Copy link
Member

saper commented Mar 8, 2015

Please see #694 (comment) why I think we should use NODE_MODULE_VERSION instead.

jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants