This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Code: Don't throw from interim callback state #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lets the error propagate to libsass. This goes against the concept of fast aborting, but this way downstream user will not get a blunt exception, but receive a well-formatted JSON error. Note: this exception from importer callback's post-process handler cannot be captured by try- catch. The edit in binding.cpp is also required, because those conditions will never get satisfied anyway. Removed due to aforementioned reasons.
am11
added
Feature - Implementation
Dev - Needs Review
and removed
Dev - Needs Review
labels
am11
added a commit
that referenced
this pull request
Apr 6, 2015
Code: Don't throw from interim callback state
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets the error propagate to libsass.
This goes against the concept of fast aborting,
but this way downstream user will not get a blunt
exception, but receive a well-formatted JSON
error.
Note: this exception from importer callback's
post-process handler cannot be captured by try-
catch.
The edit in binding.cpp is also required, because
those conditions will never get satisfied anyway.
Removed due to aforementioned reasons.