Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable LibSass specs for @content args #1313

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Enable LibSass specs for @content args #1313

merged 1 commit into from
Nov 26, 2018

Conversation

xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Nov 25, 2018

[skip libsass]

xzyfer added a commit to sass/libsass that referenced this pull request Nov 25, 2018
@xzyfer
Implement passing arguments to @content
babf69a 
See sass/sass#871
Spec sass/sass-spec#1313
Fixes #2723
@xzyfer xzyfer mentioned this pull request Nov 25, 2018
Merged
xzyfer added a commit to sass/libsass that referenced this pull request Nov 25, 2018
@xzyfer
Implement passing arguments to @content
4fa3a03 
See sass/sass#871
Spec sass/sass-spec#1313
Fixes #2723
xzyfer added a commit to sass/libsass that referenced this pull request Nov 25, 2018
@xzyfer
Implement passing arguments to @content
cde3dd9 
See sass/sass#871
Spec sass/sass-spec#1313
Fixes #2723
xzyfer added a commit to sass/libsass that referenced this pull request Nov 25, 2018
@xzyfer
Implement passing arguments to @content
65bd3b1 
See sass/sass#871
Spec sass/sass-spec#1313
Fixes #2723
xzyfer added a commit to sass/libsass that referenced this pull request Nov 25, 2018
@xzyfer
Implement passing arguments to @content
bb7375a 
See sass/sass#871
Spec sass/sass-spec#1313
Fixes #2723
xzyfer
xzyfer commented Nov 25, 2018
View reviewed changes
spec/mixin/content/arguments/receiving/output-libsass.css
keywords: ();
}
with-splat named-passed {
keywords: (arg1: value1, arg2: value2);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed some output due to an existing issue with inspect'ing arglists that isn't related to this feature.

xzyfer added a commit to sass/libsass that referenced this pull request Nov 25, 2018
@xzyfer
Implement passing arguments to @content
8cb8a33 
See sass/sass#871
Spec sass/sass-spec#1313
Fixes #2723
xzyfer added a commit to sass/libsass that referenced this pull request Nov 25, 2018
@xzyfer
Implement passing arguments to @content
57f61c4 
See sass/sass#871
Spec sass/sass-spec#1313
Fixes #2723
xzyfer added a commit to sass/libsass that referenced this pull request Nov 26, 2018
@xzyfer
Implement passing arguments to @content
c04f5d7 
See sass/sass#871
Spec sass/sass-spec#1313
Fixes #2723
@xzyfer xzyfer merged commit 2c0086b into master Nov 26, 2018
@xzyfer xzyfer deleted the content-args branch November 26, 2018 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xzyfer