comment.hrx: libsass fixed in sass/libsass#2849 #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
added a commit
to glebm/libsass
that referenced
this pull request
Mar 25, 2019
Also: 1. Moves the `normalize*` functions and `rtrim` to a separate object file, so that they can be unit tested quickly and easily. 2. Changes `string_to_output` to also replace `\r\n`, fixing Windows tests. 3. Improves other `normalize_*` functions and adds tests. Refs sass#2843 sass-spec PRs: 1. Bug fixes to make it run: sass/sass-spec#1365 2. Enabling the newly passing tests: sass/sass-spec#1366
xzyfer
pushed a commit
to sass/libsass
that referenced
this pull request
Mar 25, 2019
Also: 1. Moves the `normalize*` functions and `rtrim` to a separate object file, so that they can be unit tested quickly and easily. 2. Changes `string_to_output` to also replace `\r\n`, fixing Windows tests. 3. Improves other `normalize_*` functions and adds tests. Refs #2843 sass-spec PRs: 1. Bug fixes to make it run: sass/sass-spec#1365 2. Enabling the newly passing tests: sass/sass-spec#1366
nex3
approved these changes
Apr 2, 2019
|
FYI, when you're adding tests for a particular implementation, you can add "[skip libsass]" (or whatever) to the PR message and the runner won't run the specs on LibSass. Then if you add "See #1366" to the corresponding LibSass PR, that runner will run the specs in this PR rather than in |
|
Ah, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs sass/libsass#2849