♿ improve accessibility and refactor headers #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip screen-reader on background texts. Update aria-label and alt text for illustrations.
Update project link titles. Make links target="_blank". Update tech stack texts with unordered list (ul) element.
Replace formatDatetime function with more accessible React component Datetime.tsx
Hide some element from screen-reader. Make carousel and image card to be lists. Add alt text for blog card cover image.
Update nav structure for both mobile and desktop instead of seperating one for mobile and desktop. Update theme button aria-label according to theme value changes.
Make mobile bottom nav position relative to viewport instead of its parent. Update header shadow on scroll.
Combine separate nav bars of blog header for mobile and desktop. Update navbar animations. Improve accessibility.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessibility Improvements ♿️