Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix numpy type hints + fix series_to_series transformers #8

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix numpy type hints + fix series_to_series transformers #8

merged 1 commit into from
Jan 10, 2024

Conversation

elineii
Copy link
Collaborator

@elineii elineii commented Jan 10, 2024

  1. Fix numpy type hints according to new version of numpy (np.int -> np.integer, np.float -> np.floating, np.str -> np.str_)
  2. Fix transform and inverse_transform functions for segments according to new version of numpy (it needs to drop id index after apply)
  3. In _pad_segment padding None has been replaced with np.nan, and further explicit types have been defined (datetime for date, int for id, float for everything else --> potentially need to convert to types from config)
  4. Fix DifferenceTransformer: there was something wrong instead of cumsum and cumprod

@elineii elineii linked an issue Jan 10, 2024 that may be closed by this pull request
LastKnownNormalizer doesn't work with FlatWideMIMOStrategy #2
Open
@DESimakov DESimakov merged commit 019a828 into development Jan 10, 2024
@elineii elineii deleted the bugfix/strategies_fix branch February 19, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DESimakov DESimakov Awaiting requested review from DESimakov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LastKnownNormalizer doesn't work with FlatWideMIMOStrategy
2 participants
@elineii @DESimakov