Use provider.getRegion() (#6)

sbstjn · Jul 29, 2017 · 4044546 · 4044546
1 parent 8ca074a
commit 4044546
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/plugin.js b/src/plugin.js
@@ -95,7 +95,7 @@ class Plugin {
  }
 
  const alarms = this.serverless.service.custom['sqs-alarms'].map(
- data => new Alarm(data, this.serverless.service.provider.region)
+ data => new Alarm(data, this.serverless.getProvider('aws').getRegion())
  )
 
  alarms.forEach(

diff --git a/test/plugin.spec.js b/test/plugin.spec.js
@@ -4,6 +4,7 @@ const Plugin = require('../')
 
 it('creates CloudFormation configuration', () => {
  let config = {
+ getProvider: () => ({ getRegion: () => 'test-region' }),
  service: {
  custom: {
  'sqs-alarms': [
@@ -14,7 +15,6 @@ it('creates CloudFormation configuration', () => {
  ]
  },
  provider: {
- region: 'test-region',
  compiledCloudFormationTemplate: {
  Resources: {}
  }
@@ -39,6 +39,7 @@ describe('alarm name', () => {
 
  beforeEach(() => {
  config = {
+ getProvider: () => ({ getRegion: () => 'test-region' }),
  service: {
  custom: {
  'sqs-alarms': [
@@ -49,7 +50,6 @@ describe('alarm name', () => {
  ]
  },
  provider: {
- region: 'test-region',
  compiledCloudFormationTemplate: {
  Resources: {}
  }
@@ -85,6 +85,7 @@ describe('alarm name', () => {
 
 it('creates alarms for multiple queues', () => {
  let config = {
+ getProvider: () => ({ getRegion: () => 'test-region' }),
  service: {
  custom: {
  'sqs-alarms': [
@@ -101,7 +102,6 @@ it('creates alarms for multiple queues', () => {
  ]
  },
  provider: {
- region: 'test-region',
  compiledCloudFormationTemplate: {
  Resources: {}
  }
@@ -122,6 +122,7 @@ it('creates alarms for multiple queues', () => {
 
 it('does not fail without configuration', () => {
  let config = {
+ getProvider: () => ({ getRegion: () => 'test-region' }),
  service: {
  custom: { },
  provider: {
@@ -145,6 +146,7 @@ describe('alarm treatMissingData', () => {
 
  beforeEach(() => {
  config = {
+ getProvider: () => ({ getRegion: () => 'test-region' }),
  service: {
  custom: {
  'sqs-alarms': [
@@ -155,7 +157,6 @@ describe('alarm treatMissingData', () => {
  ]
  },
  provider: {
- region: 'test-region',
  compiledCloudFormationTemplate: {
  Resources: {}
  }