Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA updates #540

Merged
merged 2 commits into from
Oct 20, 2024
Merged

GHA updates #540

merged 2 commits into from
Oct 20, 2024

Conversation

mzuehlke
Copy link

  • update actions/setup-java 3 -> 4
  • make jobtype more descriptive

* update actions/setup-java 3 -> 4
* make `jobtype` more descriptive
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

with:
distribution: "${{ matrix.distribution }}"
java-version: "${{ matrix.java }}"
cache: sbt
- uses: sbt/setup-sbt@v1
- name: Build and test (sbt 1.x)
if: ${{ matrix.jobtype == 1 }}
if: ${{ matrix.jobtype == sbt-1 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This failed - https:/sbt/sbt-assembly/actions/runs/11425010983

The workflow is not valid. .github/workflows/ci.yml (Line: 49, Col: 11): Unrecognized named-value: 'sbt-1'. Located at position 19 within expression: matrix.jobtype == sbt-1 .github/workflows/ci.yml (Line: 54, Col: 11): Unrecognized named-value: 'sbt-2'. Located at position 19 within expression: matrix.jobtype == sbt-2

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the missing quotes

@eed3si9n eed3si9n merged commit 19fa55e into sbt:develop Oct 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants