Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix SQLServer 2017 job #2250

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[CI] Fix SQLServer 2017 job #2250

merged 1 commit into from
Sep 24, 2024

Conversation

Torch3333
Copy link
Contributor

@Torch3333 Torch3333 commented Sep 24, 2024

Description

The CI job for SQLServer 2017 has been failing since the end of last week. It appears the SQLServer 2017 Docker container fails to start properly, cf. the logs in the "Additional notes” section below.

As a workaround, I downgraded the Github runner Ubuntu version from 22 to 20.

Related issues and/or PRs

Changes made

Downgraded the CI Github runner Ubuntu version from 22 to 20 for the SQLServer2017 job to fix a container startup issue.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

The logs for the SQLServer2017 Docker container which fails to start:

 This program has encountered a fatal error and cannot continue running at Mon Sep 23 19:57:12 2024
 The following diagnostic information is available:
 
          Reason: 0x00000001
          Signal: SIGABRT - Aborted (6)
           Stack:
                  IP               Function
                  ---------------- --------------------------------------
                  00005602c59be49c <unknown>
                  00005602c59bdee2 <unknown>
                  00005602c59bd4f1 <unknown>
                  00007f110b8e5f10 killpg+0x40
                  00007f110b8e5e87 gsignal+0xc7
                  00007f110b8e77f1 abort+0x141
                  00005602c5944e42 <unknown>
                  00005602c59cbcb4 <unknown>
 SQL Server 2017 will run as non-root by default.
 This container is running as user root.
 To learn more visit https://go.microsoft.com/fwlink/?linkid=2099216.
 Capturing a dump of 9
 Successfully captured dump: /var/opt/mssql/log/core.sqlservr.9_23_2024_19_57_13.9
 Executing: /opt/mssql/bin/handle-crash.sh with parameters
      handle-crash.sh
      /opt/mssql/bin/sqlservr
      9
      /opt/mssql/bin
      /var/opt/mssql/log/
      
      0aec4be1-d47a-40d2-9415-c5eaae487283
      67b0f9db-2f8b-4e5e-becb-1881acf2cae1
      
      /var/opt/mssql/log/core.sqlservr.9_23_2024_19_57_13.9
 
 Ubuntu 18.04.6 LTS
 Capturing core dump and information to /var/opt/mssql/log...
 Mon Sep 23 19:57:14 UTC 2024 Capturing program information
 Dump already generated: /var/opt/mssql/log/core.sqlservr.9_23_2024_19_57_13.9, moving to /var/opt/mssql/log/core.sqlservr.9.temp/core.sqlservr.9.gdmp
 Moving logs to /var/opt/mssql/log/core.sqlservr.9.temp/log/paldumper-debug.log
 Mon Sep 23 19:57:14 UTC 2024 Capturing program binaries
 Mon Sep 23 19:57:14 UTC 2024 Not compressing the dump files, moving instead to: /var/opt/mssql/log/core.sqlservr.09_23_2024_19_57_13.9.d
                  00005602c59ff1f8 <unknown>
                  00005602c59fefda <unknown>
                  00005602c5950cba <unknown>
                  00005602c595090f <unknown>
         Process: 9 - sqlservr
          Thread: 81 (application thread 0x138)
     Instance Id: 0aec4be1-d47a-40d2-9415-c5eaae487283
        Crash Id: 67b0f9db-2f8b-4e5e-becb-1881acf2cae1
     Build stamp: a061e85be3fdd5c8d55a05c62bda0b9e1d6d267f3cac4d70d78ec1a9a6f57be0
    Distribution: Ubuntu 18.04.6 LTS
      Processors: 4
    Total Memory: 16766771200 bytes
       Timestamp: Mon Sep 23 19:57:12 2024
      Last errno: 2
 Last errno text: No such file or directory
 dmesg: read kernel buffer failed: Operation not permitted
 /usr/bin/timeout: failed to run command '/bin/journalctl': No such file or directory
 /usr/bin/timeout: failed to run command '/bin/journalctl': No such file or directory
Stop and remove container: ef9749a2c27d44508d87f3d840135caa_mcrmicrosoftcommssqlserver2017latest_a21999
/usr/bin/docker rm --force e10554f08e7076e63739056880a392e14e57d44332eaeb1cf01b9199be3e1398
e10554f08e7076e63739056880a392e14e57d44332eaeb1cf01b9199be3e1398
Remove container network: github_network_ae228a4c3233440c8321937a87f4f648
/usr/bin/docker network rm github_network_ae228a4c3233440c8321937a87f4f648
github_network_ae228a4c3233440c8321937a87f4f648

Release notes

N/A

@Torch3333 Torch3333 changed the title Set reviewers for actions group updates [CI] Fix SQLServer 2017 job Sep 24, 2024
@Torch3333 Torch3333 marked this pull request as ready for review September 24, 2024 00:27
@Torch3333 Torch3333 self-assigned this Sep 24, 2024
@Torch3333 Torch3333 added bugfix github_actions Pull requests that update GitHub Actions code labels Sep 24, 2024
@@ -1055,7 +1055,7 @@ jobs:

integration-test-for-jdbc-sqlserver-2017:
name: SQL Server 2017 integration test (${{ matrix.mode.label }})
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need the same change for integration-test-for-jdbc-sqlserver-2019 and integration-test-for-jdbc-sqlserver-2022?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other SQL Server versions do not seem affected by this bug so I kept them as is.

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@kota2and3kan kota2and3kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for fixing it! 🙇‍♀️

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@brfrn169 brfrn169 merged commit 864e5fb into master Sep 24, 2024
46 checks passed
@brfrn169 brfrn169 deleted the fix_sqlserver_2017 branch September 24, 2024 01:01
feeblefakie pushed a commit that referenced this pull request Sep 24, 2024
feeblefakie pushed a commit that referenced this pull request Sep 24, 2024
Torch3333 added a commit that referenced this pull request Sep 24, 2024
# Conflicts:
#	.github/workflows/ci.yaml
Torch3333 added a commit that referenced this pull request Sep 24, 2024
# Conflicts:
#	.github/workflows/ci.yaml
Torch3333 added a commit that referenced this pull request Sep 24, 2024
# Conflicts:
#	.github/workflows/ci.yaml
Torch3333 added a commit that referenced this pull request Sep 24, 2024
# Conflicts:
#	.github/workflows/ci.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants