Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetalK8s UI Dashboard Network Plane Health #3511

Open
ChengYanJin opened this issue Aug 29, 2021 · 0 comments
Open

MetalK8s UI Dashboard Network Plane Health #3511

ChengYanJin opened this issue Aug 29, 2021 · 0 comments
Assignees
Labels
complexity:easy Something that requires less than a day to fix priority:urgent Any issue we should jump in as soon as possible topic:ui UI-related issues

Comments

@ChengYanJin
Copy link
Contributor

Component: UI, monitoring

Why this is needed:
To display the health of Control Plane Network and Workload Plane Network.
And being able to bring the users to the Alert Page if the health status is NOT healthy.

What should be done:
Graphic design:
image

The interaction design should be the same as this:
https://www.figma.com/proto/N2jOAK44dTSiBclDjXzz6a/Next_Gen_Design?node-id=301%3A116&viewport=1035%2C-840%2C0.23489561676979065&scaling=min-zoom&page-id=180%3A3495

Implementation proposal (strongly recommended):
Technical proposal:
We haven't deploy Alert ControlPlaneNetworkDegraded and WorkloadPlaneNetworkDegraded, only NetworkDegraded is avaiable. So baically we use the same alert(NetworkDegraded) to compute the health of control plane network and workload plane network.

So I suggest we update the getNetworksAlertSelectors in shell-ui as shown below:

export const getNetworksAlertSelectors = (): FilterLabels => {
  return {
    alertname: ['NetworkDegraded'],
  };
};

And retrieve the selector in MetalK8s UI as it's done for other selectors.

Test plan:
Unit test

@ChengYanJin ChengYanJin added topic:ui UI-related issues complexity:easy Something that requires less than a day to fix priority:urgent Any issue we should jump in as soon as possible labels Aug 29, 2021
@ChengYanJin ChengYanJin added this to the MetalK8s 2.11.0 milestone Aug 29, 2021
JulienMeziere added a commit that referenced this issue Sep 15, 2021
…e HealthItem component with it

		Add DashboardPlane component containing 2 HealthItems
		Add tests for the new DashbordPlane component

	closes issue:	#3511
	closes ticket:	ARTESCA-1878
JulienMeziere pushed a commit that referenced this issue Sep 15, 2021
		Remove the ServiceItem from DashboardServices and create the HealthItem component with it
		Add DashboardPlane component containing 2 HealthItems
		Add tests for the new DashbordPlane component
		history.push replaced by history.replace in the HealthItem component
		useless comment removed in HealthItem component

	closes issue:	#3511
	closes ticket:	ARTESCA-1878
JulienMeziere pushed a commit that referenced this issue Sep 15, 2021
		Remove the ServiceItem from DashboardServices and create the HealthItem component with it
		Add DashboardPlane component containing 2 HealthItems
		Add tests for the new DashbordPlane component
		history.push replaced by history.replace in the HealthItem component
		useless comment removed in HealthItem component
Ref:	#3511
JulienMeziere pushed a commit that referenced this issue Sep 17, 2021
		Remove the ServiceItem from DashboardServices and create the HealthItem component with it
		Add DashboardPlane component containing 2 HealthItems
		Add tests for the new DashbordPlane component
		history.push replaced by history.replace in the HealthItem component
		useless comment removed in HealthItem component
Ref:	#3511
JulienMeziere pushed a commit that referenced this issue Sep 17, 2021
		Remove the ServiceItem from DashboardServices and create the HealthItem component with it
		Add DashboardPlane component containing 2 HealthItems
		Add tests for the new DashbordPlane component
		history.push replaced by history.replace in the HealthItem component
		useless comment removed in HealthItem component
Ref:	#3511
ChengYanJin pushed a commit that referenced this issue Sep 23, 2021
Remove the ServiceItem from DashboardServices and create the HealthItem component with it
Add DashboardPlane component containing 2 HealthItems
Add tests for the new DashbordPlane component
history.push replaced by history.replace in the HealthItem component

Ref: #3511
ChengYanJin pushed a commit that referenced this issue Sep 23, 2021
Remove the ServiceItem from DashboardServices and create the HealthItem component with it
Add DashboardPlane component containing 2 HealthItems
Add tests for the new DashbordPlane component
history.push replaced by history.replace in the HealthItem component

Ref: #3511
JBWatenbergScality pushed a commit that referenced this issue Sep 23, 2021
Remove the ServiceItem from DashboardServices and create the HealthItem component with it
Add DashboardPlane component containing 2 HealthItems
Add tests for the new DashbordPlane component
history.push replaced by history.replace in the HealthItem component

Ref: #3511
JBWatenbergScality pushed a commit that referenced this issue Sep 24, 2021
Remove the ServiceItem from DashboardServices and create the HealthItem component with it
Add DashboardPlane component containing 2 HealthItems
Add tests for the new DashbordPlane component
history.push replaced by history.replace in the HealthItem component

Ref: #3511
JBWatenbergScality pushed a commit that referenced this issue Sep 24, 2021
Remove the ServiceItem from DashboardServices and create the HealthItem component with it
Add DashboardPlane component containing 2 HealthItems
Add tests for the new DashbordPlane component
history.push replaced by history.replace in the HealthItem component

Ref: #3511
JBWatenbergScality pushed a commit that referenced this issue Sep 28, 2021
Remove the ServiceItem from DashboardServices and create the HealthItem component with it
Add DashboardPlane component containing 2 HealthItems
Add tests for the new DashbordPlane component
history.push replaced by history.replace in the HealthItem component

Ref: #3511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:easy Something that requires less than a day to fix priority:urgent Any issue we should jump in as soon as possible topic:ui UI-related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants