-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are there plans for a dedicated invitation model? #888
Comments
I'm open to change to independent model, with own table, with a polymorphic belongs_to to support adding invitable to multiple models. However, it isn't simple task, and I don't have plans to do it shortly. If someone sends a PR I will review it to merge it, or I could help with the change, but I don't have much time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey 😄
I tried to move the invitation into a dedicated
Invitation
model. Main reason for that attempt was that most users never are invited. So why having those extra attributes for them? And furthermore it feels natural. LikeUser
has one invitation.However I simply delegated the attributes to the dedicated
Invitation
model, like:But had to stop because finding a user by its invitation token heavily relies on the Devise#find_or_initialize_with_error_by
which I obviously don't wanna screw up.
So I think it is currently not easy to extract the invitation into a dedicated model.
My question: Are there plans in regards to this? Does it make sense from your side?
The text was updated successfully, but these errors were encountered: