Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix embedded cover art #2

Merged
merged 3 commits into from
Mar 16, 2021
Merged

Fix embedded cover art #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70a4d4b
Fix cover art based on pauloup:fixcoverart
Mar 12, 2021
7aa4c38
Bump version
Mar 12, 2021
b636c16
Fix urllib call
Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def _read(fn):

setup(
name='spotify-ripper',
version='2.15',
version='2.17',
packages=find_packages(exclude=["tests"]),
#scripts=['spotify_ripper/main.py'],
include_package_data=True,
Expand Down
22 changes: 13 additions & 9 deletions spotify_ripper/tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import os
import sys
import base64
import urllib.request


def set_metadata_tags(args, audio_file, idx, track, ripper):
Expand Down Expand Up @@ -65,16 +66,19 @@ def set_metadata_tags(args, audio_file, idx, track, ripper):
genres_ascii = [to_ascii(genre) for genre in genres]

# cover art image
image = None
if args.large_cover_art:
image = ripper.web.get_large_coverart(track.link.uri)
def get_cover_image(image_link):
image_link = 'https://i.scdn.co%s' % (
image_link[len('spotify'):].replace(':', '/'))
cover_file = urllib.request.urlretrieve(image_link)[0]

with open(cover_file, "rb") as f:
if f.mode == "rb":
return f.read()
else:
return None

# if we fail, use regular cover size
if image is None:
image = track.album.cover()
if image is not None:
image.load(args.timeout)
image = image.data
image_link = str(track.album.cover(2).link)
image = get_cover_image(image_link)

def tag_to_ascii(_str, _str_ascii):
return _str if args.ascii_path_only else _str_ascii
Expand Down