Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The function creates two entries for last day per token. Some dates are missing in the history. #9

Open
swissecon-cryptecon opened this issue Aug 21, 2018 · 1 comment

Comments

@swissecon-cryptecon
Copy link

swissecon-cryptecon commented Aug 21, 2018

The function creates two entries for last day per token. Some dates are missing in the history.

Reasons

  1. For the current day, coincap lists two entries: one at the beginning of the day and one at the time of measurement (coincap updates figures each second). Suggestion: Delete the last observation.

  2. It seems as if Coincap.io does not measure its figures every day at the same time. Over time the measurement is later more and more. If they are around midnight Coincap.io skips a day (see the attached figure). Could the issue also be a result of the date conversion?

image

@schaer-unibas
Copy link
Owner

Hi @swissecon-cryptecon thanks for reporting the issue.

  • The conversion looks fine. I suppose if it were a problem with the conversion, we should be able to identify a regular pattern. A peer-review would be much appreciated.
  • For the coinPlot() function in this package the irregular samples aren't necessarily a problem. The coinPlot() function is able to handle varying observation intervals. However, I agree that this is an issue if (a) coincap doesn't randomly select their samples and (b) if you want to use the data for more advanced analysis. Unfortunately, we are unable to change the data quality provided by coincap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants