Update config._getconftest_pathlist for pytest-dev #157
Conversation
|
Something else need changing to be compatible with pytest-dev |
pytest_doctestplus/plugin.py
Outdated
| @@ -203,10 +210,10 @@ def collect(self): | |||
| self.fspath) | |||
| else: | |||
| try: | |||
| module = self.fspath.pyimport() | |||
| module = fspath.pyimport() | |||
There was a problem hiding this comment.
This change broke something.
There was a problem hiding this comment.
Yeah, that method doesn't exist on Path objects, so I will need to reimplement it I guess.
| except TypeError: | ||
| # Pytest 7.0+ |
There was a problem hiding this comment.
Why not doing version check here?
There was a problem hiding this comment.
I forgot about it ;). And this is a bit of a mess, some changes are in 6.3 which is not released yet, and some will be in 7.0. And dev is currently 6.3.devXXX though it includes the 7.0 changes apparently.
So I added PYTEST_GT_6_3 after but I'm still not sure if that's a good idea.
There was a problem hiding this comment.
I mean try/except is easy to do, distinguishing 6.3 and 7.0 is currently not obvious.
There was a problem hiding this comment.
Okay, maybe we can merge as is but open issue to revisit in the future because you don't want the stable pytest to keep hitting the except block.
Hah, me too! 😸 |
Ref pytest-dev/pytest#7870
Close #156