Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail gracefully on SPLASH_URL without protocol #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gallaecio
Copy link
Contributor

@Gallaecio Gallaecio commented Apr 5, 2019

Fixes #120

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #214 into master will increase coverage by 0.37%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   92.67%   93.05%   +0.37%     
==========================================
  Files           9        9              
  Lines         587      590       +3     
  Branches      118      119       +1     
==========================================
+ Hits          544      549       +5     
+ Misses         21       20       -1     
+ Partials       22       21       -1
Impacted Files Coverage Δ
scrapy_splash/middleware.py 90.56% <100%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e40ca4f...9caf83d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant