Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deleted] Add autocomplete / predictive text #3

Closed
andrewtavis opened this issue Nov 22, 2021 · 7 comments
Closed

[Deleted] Add autocomplete / predictive text #3

andrewtavis opened this issue Nov 22, 2021 · 7 comments
Labels
-priority- High priority feature New feature or request help wanted Extra attention is needed wontfix This will not be worked on

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Nov 22, 2021

A major system keyboard feature that Scribe still lacks is autocomplete. This feature would ideally function in both the normal text proxy and the Scribe command bar so that a user could quickly type in a word to translate, conjugate or get the plural for. The data for each Scribe keyboard could likely be used as a reference for this feature.

Discussions of how best to implement this feature and code contributions are more than welcome!

  • Autocorrect is another related and necessary feature and is covered in Add autocorrect #2
  • This issue is related to Add menu to Scribe app #16 as some users would doubtless like to not have this feature to allow them to practice more (spell check will show if the typed word is wrong)
@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed -priority- High priority labels Nov 22, 2021
@andrewtavis andrewtavis mentioned this issue Nov 22, 2021
2 tasks
@andrewtavis andrewtavis changed the title Add autocomplete (functionality) Feature: Add autocomplete Nov 22, 2021
@andrewtavis andrewtavis changed the title Feature: Add autocomplete Add autocomplete Nov 30, 2021
@andrewtavis
Copy link
Member Author

UILexicon will be used for this, as it contains unpaired lists of names in the user's address book. Added to this can be the words found as keys in the Data directory of each keyboard.

@andrewtavis
Copy link
Member Author

andrewtavis commented Jan 19, 2022

It would be best if this feature was fully contained within the command bar. The buttons used for Translate, Conjugate, and Plural could have suggestions mapped to them, with the buttons themselves being hidden, and a simple barrier between them (this could be added to the .xib in the space between the buttons).

The issue is that the prompt for the commands in the command bar would take up some space. This could be rectified by allowing only as many suggestions as would fit given the text being typed into the command bar, with the suggestion boxes disappearing if the text reaches them. The translate prompt should be shortened in this case, with just the ISO 639-1 codes for the source and target language sufficing (ex: en > de:, with the first button being used as the interface to select translation languages as scribe-org/Scribe-Data#17 adds non English to target translations).

The size of the prompt could also be controlled for as in system keyboards. As the word gets longer, only the end of the suggestion is shown, with the letters before those that are not shown being greyed slightly to indicate that there is content that is not being shown.

@andrewtavis
Copy link
Member Author

The translate prompt will be shortened in the v1.2.0 design release using right chevrons as a delimiter en › de:.

@andrewtavis
Copy link
Member Author

Autocomplete needs to have two different functions - one for the word that is currently being typed where all scribe command button fields would have suggestions, and one for when space is pressed where annotation would be one of the spaces and the others are populated with suggestions for the next word.

@andrewtavis andrewtavis changed the title Add autocomplete Add autocomplete / predictive text Feb 13, 2022
@andrewtavis
Copy link
Member Author

andrewtavis commented Apr 4, 2022

Any codes for this that can be should be added into a file autocomplete.swift in Keyboards/KeyboardsBase.

@andrewtavis
Copy link
Member Author

@andrewtavis andrewtavis mentioned this issue Aug 14, 2022
2 tasks
@andrewtavis andrewtavis changed the title Add autocomplete / predictive text [deleted] Add autocomplete / predictive text Sep 3, 2022
@andrewtavis
Copy link
Member Author

Deleting this as #188 and #194 are covering the majority of this issue. New issues can be opened later for more advanced versions :)

@andrewtavis andrewtavis added the wontfix This will not be worked on label Apr 7, 2023
@andrewtavis andrewtavis changed the title [deleted] Add autocomplete / predictive text [Deleted] Add autocomplete / predictive text Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-priority- High priority feature New feature or request help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant