feature(artifact_test): testing the output of perftune.py #8788
Conversation
|
|
fruch
force-pushed
the
performance_tuning
branch
9 times, most recently
from
cb8795c
to
c0e089a
Compare
fruch
force-pushed
the
performance_tuning
branch
7 times, most recently
from
1adc58d
to
84b9a41
Compare
perftune.py is a script within seastar (which is a part of scylla_setup) that configures several system parameters, like the amount of CPU cores that are designated to handle IRQ, and which are not. I have recorded the expected results as of master 20230717.567b4536892f in defaults/perftune_results.json, and the test will compare them to the output of the script. Ref: scylladb/scylla-enterprise#2909
fruch
force-pushed
the
performance_tuning
branch
from
84b9a41
to
f1fac7c
Compare
| self.architecture = architecture | ||
| self.expected_compute_bits: int = 0 | ||
|
|
||
| match number_of_cpu_cores: |
There was a problem hiding this comment.
here's the new logic, it's just maps to how many irq cpus we expect.
| self.compare_cpu_mask() | ||
| self.compare_irq_cpu_mask() | ||
| if not self.node.is_nonroot_install: | ||
| # The following checks are not applicable for non-root installations, |
There was a problem hiding this comment.
I don't know if it's intended or not, but non-root installs doesn't call perftune at all.
fruch
added
backport/2024.1
|
@roydahan have you seen this one ? |
| self.expected_irq_bits: int = 2 | ||
| case 16: | ||
| if self.architecture == "aarch64": | ||
| self.expected_irq_bits: int = 1 |
There was a problem hiding this comment.
@vladzcloudius isn't this a bug?
Why would we set only 1 core for irq in arm?
| try: | ||
| self.compare_cpu_mask() | ||
| self.compare_irq_cpu_mask() | ||
| if not self.node.is_nonroot_install: |
There was a problem hiding this comment.
could return here to drop nesting.
defaults you mean the content of |
yes, how much we differ from that - shouldn't be much (what is much I don't know yet) |
perftune.py is a script within seastar (which is a part of scylla_setup) that configures several system parameters, like the amount of CPU cores that are designated to handle IRQ, and which are not.
Ref: https:/scylladb/scylla-enterprise/issues/2909
Replacement of #6192
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)