Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(gemini): run gemini from scylladb/gemini #8953

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CodeLieutenant
Copy link
Contributor

@CodeLieutenant CodeLieutenant commented Oct 10, 2024

Dockerfile has been moved to gemini project, and now SCT should use that image.

Changes:

  • Use image from scylladb/gemini
  • Remove dockerfile for gemini and point in readme location for the images
  • Add CQL Statement Logging to gemini output
  • Forward outputs from docker to $HOME/*.log
  • Run default gemini flags from gemini_thread.py

Testing

Dockerfile has been moved to gemini project, and now
SCT should use that image.

Changes:
- Use image from scylladb/gemini
- Remove dockerfile for gemini and point in readme location for the
  images
- Add CQL Statement Logging to gemini output
- Forward outputs from docker to $HOME/*.log
- Run default gemini flags from gemini_thread.py

Signed-off-by: Dusan Malusev <[email protected]>
@CodeLieutenant CodeLieutenant added backport/none Backport is not required test-integration Enable running the integration tests suite labels Oct 10, 2024
@CodeLieutenant CodeLieutenant self-assigned this Oct 10, 2024
@fruch
Copy link
Contributor

fruch commented Oct 10, 2024

@CodeLieutenant

I want to see a 10h run, with the statements logs, so we can see how bad is it (in size).

@CodeLieutenant
Copy link
Contributor Author

@CodeLieutenant

I want to see a 10h run, with the statements logs, so we can see how bad is it (in size).

I'm starting a new run right now, I'll reference it when it's started.
Branch name change maked other run invalid

@fruch
Copy link
Contributor

fruch commented Oct 13, 2024

@CodeLieutenant

from the 10h run (that lasted 12min)
seems like some parameters are not pass down correctly to the gemini command:

09:46:31  < t:2024-10-11 06:46:31,119 f:gemini_thread.py l:171  c:sdcm.gemini_thread   p:ERROR > Error: gemini encountered errors, exiting with non zero status
09:46:31  < t:2024-10-11 06:46:31,119 f:gemini_thread.py l:171  c:sdcm.gemini_thread   p:ERROR > /bin/sh: --warmup: not found
09:46:31  < t:2024-10-11 06:46:31,119 f:gemini_thread.py l:171  c:sdcm.gemini_thread   p:ERROR > /bin/sh: --concurrency: not found
09:46:31  < t:2024-10-11 06:46:31,119 f:gemini_thread.py l:171  c:sdcm.gemini_thread   p:ERROR > /bin/sh: --mode: not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/none Backport is not required test-integration Enable running the integration tests suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants