Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2023.1] improvement(reporting): Add argus links to email template and elastic #8956

Open
wants to merge 1 commit into
base: branch-2023.1
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Oct 10, 2024

This commit adds links to argus to the elastic search index and email
templates, allowing users to find argus runs quickly from those places.

Fixes scylladb/qa-tasks#1490

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

(cherry picked from commit 8175f82 )

Parent PR: #8952

@mergify mergify bot added the conflicts label Oct 10, 2024
Copy link
Author

mergify bot commented Oct 10, 2024

Cherry-pick of 8175f82 has failed:

On branch mergify/bp/branch-2023.1/pr-8952
Your branch is up to date with 'origin/branch-2023.1'.

You are currently cherry-picking commit 8175f8279.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   sdcm/report_templates/results_base.html

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   sdcm/reporting/elastic_reporter.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot marked this pull request as draft October 10, 2024 08:41
@fruch fruch force-pushed the mergify/bp/branch-2023.1/pr-8952 branch from 5e677f8 to 32b246e Compare October 13, 2024 13:19
@fruch fruch removed the conflicts label Oct 13, 2024
@fruch fruch marked this pull request as ready for review October 13, 2024 13:19
This commit adds links to argus to the elastic search index and email
templates, allowing users to find argus runs quickly from those places.

Fixes scylladb/qa-tasks#1490

(cherry picked from commit 8175f82)
@fruch fruch force-pushed the mergify/bp/branch-2023.1/pr-8952 branch from 32b246e to 38e7ebe Compare October 13, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants