nodetool: compact: add --offstrategy option #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhalevy
force-pushed
the
trigger_offstrategy_compaction
branch
from
012c7c2
to
1f79949
Compare
I think so. In most of the cases, user will not call nodetool triggeroffstrategycompaction at all. The cluster will trigger it automatically. In practice, the 5 minutes automatic timeout is supposed to be much less than the repair time. |
|
On Fri, Jul 30, 2021 at 8:36 AM Asias He ***@***.***> wrote:
@bhalevy <https:/bhalevy> @tzach <https:/tzach>
Would not adding a flag to nodetool compact make more sense for
discoverability?
I think so. In most of the cases, user will not call nodetool
triggeroffstrategycompaction at all. The cluster will trigger it
automatically. In practice, the 5 minutes automatic timeout is supposed to
be much less than the repair time.
agreed. better to add an --off-strategy flag instead.
… —
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#269 (comment)>,
or unsubscribe
<https:/notifications/unsubscribe-auth/AAKYA47VPU4DQMONORRSP3DT2KFD7ANCNFSM5A75YMZA>
.
|
To trigger offstrategy compaction. e.g. immediately after repair completes. Otherwise, it is auto-triggered after a 5 minutes idle timeout. Signed-off-by: Benny Halevy <[email protected]>
bhalevy
force-pushed
the
trigger_offstrategy_compaction
branch
from
1f79949
to
41733e9
Compare
bhalevy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To trigger offstrategy compaction. e.g. immediately after repair completes.
Otherwise, it is auto-triggered after a 5 minutes idle timeout.
Depends on scylladb/scylla-jmx#172 and (indirectly) on scylladb/scylladb#9095
Signed-off-by: Benny Halevy [email protected]