Fix stuck keys when dragging on piano view (LMMS#5127)

* Fix stuck keys when dragging on piano view * Add comment Co-Authored-By: Shmuel H. <[email protected]>
sdasda7777 · Sep 8, 2019 · cebc669 · cebc669
1 parent dcbaf70
commit cebc669
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/core/NotePlayHandle.cpp b/src/core/NotePlayHandle.cpp
@@ -199,7 +199,12 @@ void NotePlayHandle::play( sampleFrame * _working_buffer )
 
  lock();
 
- if( m_totalFramesPlayed == 0 && !m_hasMidiNote
+ /* It is possible for NotePlayHandle::noteOff to be called before NotePlayHandle::play,
+ * which results in a note-on message being sent without a subsequent note-off message.
+ * Therefore, we check here whether the note has already been released before sending
+ * the note-on message. */
+ if( !m_released
+ && m_totalFramesPlayed == 0 && !m_hasMidiNote
  && ( hasParent() || ! m_instrumentTrack->isArpeggioEnabled() ) )
  {
  m_hasMidiNote = true;