Skip to content

Commit

Permalink
Adjust log initialization position in MainApp
Browse files Browse the repository at this point in the history
In the MainApp class, let's move the call to the initLogging method
closer to the start of the execution start point, to minimize the
possibility of log statements being executed before the desired log
level is set.
  • Loading branch information
Eclipse-Dominator committed Aug 15, 2023
1 parent a798252 commit 2d172b9
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/main/java/seedu/address/MainApp.java
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,13 @@ public void init() throws Exception {

AppParameters appParameters = AppParameters.parse(getParameters());
config = initConfig(appParameters.getConfigPath());
initLogging(config);

Check warning on line 56 in src/main/java/seedu/address/MainApp.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/seedu/address/MainApp.java#L56

Added line #L56 was not covered by tests

UserPrefsStorage userPrefsStorage = new JsonUserPrefsStorage(config.getUserPrefsFilePath());
UserPrefs userPrefs = initPrefs(userPrefsStorage);
AddressBookStorage addressBookStorage = new JsonAddressBookStorage(userPrefs.getAddressBookFilePath());
storage = new StorageManager(addressBookStorage, userPrefsStorage);

initLogging(config);

model = initModelManager(storage, userPrefs);

logic = new LogicManager(model, storage);
Expand Down

0 comments on commit 2d172b9

Please sign in to comment.