-
Notifications
You must be signed in to change notification settings - Fork 9
<scm><tag> value overwritten with invalid tag value #24
Comments
If you don't want the defaults that If you specify You're a power user who wants different defaults -- you are not the target user for |
Might I suggest an update to the build-clj documentation then, to make it clear that The behaviour you're describing for build-clj's handling of |
Feel free to submit a documentation PR but you're the only person who has been caught out by the behavior so far - because you're not the target user for this library. |
Thanks, but if I'm "not the target user for this library" I'm disinclined to contribute to it any further than I already have. |
This is two interrelated issues:
First, when a source
pom.xml
exists, and the<scm><tag>
element in it already has a value, build-clj unconditionally overwrites the value of that element in the duplicatepom.xml
file that is written to META-INF when the existing value from the sourcepom.xml
should be preserved instead. Yes(:tag opts)
can be used to override this behaviour, but it is reasonable to expect that build-clj would preserve all values found in the sourcepom.xml
, without needing to be told to do so elsewhere.Second, even in the case where that element doesn't exist in the source
pom.xml
file, build-clj assumes GitHub tags of the form"v(:version opts)"
, which is not guaranteed to be a valid tag in the source GitHub repo. In fact many GitHub repos label tags with raw version numbers without any prefix, and this then causes problems for downstream tools that use the value of the<scm><tag>
element for their own processing, for example cljdoc.See also this Clojars issue, where this issue was initially discussed.
The text was updated successfully, but these errors were encountered: