Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecation notices for assertObject[Not]HasAttribute() in PHPUnit 9.6 once PHPUnit 10.1 has been released #5295

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Apr 1, 2023

... now PHPUnit 10.1.0 introduces the assertObjectHasProperty() and assertObjectNotHasProperty() methods.

Refs:


Note: probably best to merge just before the 10.1.0 release ?

…ute()

... now PHPUnit 10.1.0 introduces the `assertObjectHasProperty()` and `assertObjectNotHasProperty()` methods.

Refs:
* sebastianbergmann#5231
* sebastianbergmann@f18856c
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #5295 (5600c4f) into 9.6 (d781fac) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                9.6    #5295   +/-   ##
=========================================
  Coverage     83.17%   83.17%           
  Complexity     4615     4615           
=========================================
  Files           271      271           
  Lines         13661    13661           
=========================================
  Hits          11363    11363           
  Misses         2298     2298           
Impacted Files Coverage Δ
src/Framework/Assert.php 92.22% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sebastianbergmann sebastianbergmann added this to the PHPUnit 10.1 milestone Apr 2, 2023
@sebastianbergmann sebastianbergmann self-assigned this Apr 2, 2023
@sebastianbergmann sebastianbergmann added type/deprecation Something will be/is deprecated version/9 Something affects PHPUnit 9 labels Apr 2, 2023
@sebastianbergmann sebastianbergmann changed the title PHPUnit 9 | Update deprecation notices for assertObject[Not]HasAttribute() Update deprecation notices for assertObject[Not]HasAttribute() in PHPUnit 9.6 once PHPUnit 10.1 has been released Apr 2, 2023
@sebastianbergmann sebastianbergmann merged commit 5a0a0de into sebastianbergmann:9.6 Apr 11, 2023
@jrfnl jrfnl deleted the feature/improve-some-deprecation-notices branch April 11, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/deprecation Something will be/is deprecated version/9 Something affects PHPUnit 9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants