Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of SurvivalTree #371

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Improve performance of SurvivalTree #371

merged 1 commit into from
Jun 10, 2023

Conversation

sebp
Copy link
Owner

@sebp sebp commented Jun 9, 2023

Checklist

What does this implement/fix? Explain your changes

  • Construct total risk set without sorting
  • Compute risk set for left node on the fly
  • Rename event_times_ attribute to unique_times_ everywhere

- Construct total risk set without sorting
- Compute risk set for left node on the fly
- Rename event_times_ to unique_times_ everywhere

Fixes #343
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (07bce96) 97.92% compared to head (dc6c3ac) 97.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #371   +/-   ##
=======================================
  Coverage   97.92%   97.92%           
=======================================
  Files          37       37           
  Lines        3324     3326    +2     
  Branches      502      502           
=======================================
+ Hits         3255     3257    +2     
  Misses         33       33           
  Partials       36       36           
Impacted Files Coverage Δ
sksurv/ensemble/boosting.py 97.47% <100.00%> (ø)
sksurv/ensemble/forest.py 100.00% <100.00%> (ø)
sksurv/linear_model/coxnet.py 97.33% <100.00%> (ø)
sksurv/linear_model/coxph.py 95.33% <100.00%> (ø)
sksurv/tree/tree.py 95.27% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sebp sebp merged commit d233c6f into master Jun 10, 2023
@sebp sebp deleted the fix-rsf-performance branch June 10, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RandomSurvivalForest unusally slow
1 participant