Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX LogrankCriterion does not consider sample_weight #464

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Conversation

sebp
Copy link
Owner

@sebp sebp commented Jun 29, 2024

Checklist

What does this implement/fix? Explain your changes
Incorporate sample weights into the LogrankCriterion that is used to compute the split criteria used in SurvivalTree.

Notably, this affects RandomSurvivalForest and ExtraSurvivalTrees too, because individual trees in the forests are passed sample_weight.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bceb53e) 3526 3495 99.12%
Head commit (769ea89) 3526 (+0) 3495 (+0) 99.12% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#464) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (bceb53e) to head (769ea89).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #464   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files          37       37           
  Lines        3526     3526           
  Branches      539      539           
=======================================
  Hits         3461     3461           
  Misses         31       31           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebp sebp merged commit 8305e7a into master Jun 29, 2024
31 checks passed
@sebp sebp deleted the fix/443 branch June 29, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SurvivalTree is handling sample_weight incorrectly
1 participant