Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: Improve Error Message on Failed Attachment of Finding #120

Merged

Conversation

Weltraumschaf
Copy link
Member

@Weltraumschaf Weltraumschaf commented Feb 14, 2024

This PR ports this enhancement into main branch.

Relates to secureCodeBox/secureCodeBox#2271

The original code does not provide the causing error, which makes
it dificult to debug the problem.

- Add first adding loggign capabilities via SLF4J.
- Log the failed attempt of attaching a finding as eror w/ original
  exception message.
- Pass the causing exception to the exception we rethrow to preserve
  the full stack trace.

Signed-off-by: Sven Strittmatter <[email protected]>
@Weltraumschaf Weltraumschaf self-assigned this Feb 14, 2024
@Weltraumschaf Weltraumschaf added the enhancement New feature or request label Feb 14, 2024
@Weltraumschaf Weltraumschaf changed the title Backport: Improve Error Message on Failed attachment of Finding Port: Improve Error Message on Failed attachment of Finding Feb 14, 2024
@Weltraumschaf Weltraumschaf changed the title Port: Improve Error Message on Failed attachment of Finding Port: Improve Error Message on Failed Attachment of Finding Feb 14, 2024
@Weltraumschaf Weltraumschaf merged commit 130a695 into secureCodeBox:main Feb 14, 2024
2 checks passed
@Weltraumschaf Weltraumschaf deleted the fix_error_handling_in_main branch February 14, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants