Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Furhtor Refactroing #123

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

Furhtor Refactroing #123

wants to merge 33 commits into from

Commits on Jul 3, 2024

  1. secureCodeBox#121 Introduce Our Own Exception Type Hierarchy 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    a1329e7 View commit details
    Browse the repository at this point in the history

  2. secureCodeBox#121 Remove Checked Exception to Provide a Cleaner API 

    Checked exceptions in a public used API is quite cumbersome. Alo
checked exceptions should onlybe used forerrors you can deal with
in the source code. Since the errors in this case origin from outside,
it is better to use runtime exceptions. This does not clutter the API
clients.

Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    9c3bd78 View commit details
    Browse the repository at this point in the history

  3. secureCodeBox#121 Use Latest Version 17 of Java 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    1a2f61a View commit details
    Browse the repository at this point in the history

  4. secureCodeBox#121 Javadoc Tool Can't Lookup Lombok Generated Stuff 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    a662260 View commit details
    Browse the repository at this point in the history

  5. secureCodeBox#121 Extract Auth Header Facotry from Intermediate Class 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f1cc201 View commit details
    Browse the repository at this point in the history

  6. secureCodeBox#121 Extract Proxy Credential Facotry from Intermediate … 

    …Class

Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    8804bf1 View commit details
    Browse the repository at this point in the history

  7. secureCodeBox#121 Log in Debug Level Which Auth Headers are Set 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    814d455 View commit details
    Browse the repository at this point in the history

  8. secureCodeBox#121 Remove Unused field from Intermediate Class 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f5ff0ae View commit details
    Browse the repository at this point in the history

  9. secureCodeBox#121 Give Config a Better Name to Make it More Distingui… 

    …shable from ProxyConfig

Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    7c192c0 View commit details
    Browse the repository at this point in the history

  10. secureCodeBox#121 Log proxi configuration 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    78f330a View commit details
    Browse the repository at this point in the history

  11. secureCodeBox#121 Do not Create Unecessary Objects 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    29ba64d View commit details
    Browse the repository at this point in the history

  12. secureCodeBox#121 Use Better Variable Name 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    4f2ee00 View commit details
    Browse the repository at this point in the history

  13. secureCodeBox#121 Extract Method to Generate Base URL 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e5368d6 View commit details
    Browse the repository at this point in the history

  14. secureCodeBox#121 Mark Dedicated Constructor 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f439576 View commit details
    Browse the repository at this point in the history

  15. secureCodeBox#121 Make Vars Final 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e9ad077 View commit details
    Browse the repository at this point in the history

  16. secureCodeBox#121 Add Bug Marker 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    28c7c4b View commit details
    Browse the repository at this point in the history

  17. secureCodeBox#121 Add Missing JavaDoc 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    eb975b1 View commit details
    Browse the repository at this point in the history

  18. secureCodeBox#121 Use URI Instead of String 

    This has theadvantage that URLs are validated in place and we can
normalize theresulting URL to remove double slashes from path.

Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    3309da3 View commit details
    Browse the repository at this point in the history

  19. secureCodeBox#121 Reformat Lambdas for Readability 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    a537644 View commit details
    Browse the repository at this point in the history

  20. secureCodeBox#121 Remove Obsolete Checked Exceptions from Method Sign… 

    …ature

Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    1ce7c07 View commit details
    Browse the repository at this point in the history

  21. secureCodeBox#121 Move Overloaded Method Before the Implemented 

    Follow the principle of more details towards the bottom of file.

Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    08f98cc View commit details
    Browse the repository at this point in the history

  22. secureCodeBox#121 Add Tests to Verify Presence of Auth Token in Headers 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    34abd4c View commit details
    Browse the repository at this point in the history

  23. secureCodeBox#121 Hide Client Config Because Only USed in This Class 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b67f8c5 View commit details
    Browse the repository at this point in the history

  24. secureCodeBox#121 Hide Rest Template Because Only USed in This Class 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    307747c View commit details
    Browse the repository at this point in the history

  25. secureCodeBox#121 Extract Proxy Config As Field to Make it Injectable… 

    … in Tests

Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e00225a View commit details
    Browse the repository at this point in the history

  26. secureCodeBox#121 Give Method Better Name Since it is Not a Simple Ge… 

    …tter

Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    9fb2b5e View commit details
    Browse the repository at this point in the history

  27. secureCodeBox#121 Add Tests to Verify Presence of Proxy Auth Header 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    d72ee2f View commit details
    Browse the repository at this point in the history

  28. secureCodeBox#121 Remove Uneccessary Indirect Call to REST Template 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    9797207 View commit details
    Browse the repository at this point in the history

  29. secureCodeBox#121 Reduce Coupling to Jackso by Extracting Mappers int… 

    …o Own Object

Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    190dfc7 View commit details
    Browse the repository at this point in the history

  30. secureCodeBox#121 Remove Uneccessary This Qualifier 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e4c7afd View commit details
    Browse the repository at this point in the history

  31. secureCodeBox#121 Give Class a More Meaningful Name 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    51c3122 View commit details
    Browse the repository at this point in the history

  32. secureCodeBox#121 Do Not Create Proxy Config Twice 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    2d58c31 View commit details
    Browse the repository at this point in the history

  33. secureCodeBox#121 Extract Request Entity Creation 

    Signed-off-by: Sven Strittmatter <[email protected]>
    @Weltraumschaf
    Weltraumschaf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    4f67514 View commit details
    Browse the repository at this point in the history