Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Zone / Single Zone button #1957

Closed
xSimone opened this issue Jan 20, 2024 · 34 comments
Closed

Multi Zone / Single Zone button #1957

xSimone opened this issue Jan 20, 2024 · 34 comments
Labels
question Further information is requested

Comments

@xSimone
Copy link

xSimone commented Jan 20, 2024

Hellu.

Because MiniLED is becoming more and more frequent to be seen on the Asus ROG Laptops, it would be nice if you could have the button like in Garbageoury Crate that allows you to toggle between Single and Multi Zone Lighting with MiniLED panels.

5ydfg8dnk0ma1

@squee666
Copy link

you can manually bind it in extras

image

@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

Oh okay that is cool, though I kind of use all my hotkeys as they're (unfortunately) labelled as. Volume down, up, mute mic, fan speed and G-Helper.

I guess I can use Mic for now. :<

Edit: It doesn't work, pressing it only gives 'Multi Mode' no 'Single Mode'

Bug! :c

@seerge
Copy link
Owner

seerge commented Jan 20, 2024

@xSimone that buttons exists in the app for ages. @squee666 has it on screenshot (red Multizone).

If you don't see it - it means that Miniled Toggle endpoint in your system doesn't exist.

Do you you have this Miniled button in AC on your specific device, and does it work ?

@seerge seerge added the question Further information is requested label Jan 20, 2024
@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

Aw I really do not want to reinstall armoury crate. :’c

I have Asus Scar 18 2024 and it has miniLED. I am sure it should have toggle but unsure.

@seerge
Copy link
Owner

seerge commented Jan 20, 2024

@xSimone well, then I have no idea if it's supported by your device or not. Easiest way is to check in AC.

Next to that you can also create a DSL dump of supported commands using Method 2 from this topic #38 .

And upload here.

@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

I DO THIS INSTEAD!!

zz.txt

@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

I will get different SSD and make install just for testing, will do this tomorrow!

@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

@squee666 what machine do you have?

Maybe Scar 18 2024 do not have the button, because MiniLED 2k is small enough to avoid the bloom issue? So they do not add this?

Can you turn off MiniLED in Windows?

@seerge
Copy link
Owner

seerge commented Jan 20, 2024

@xSimone you can just install second windows on same drive :| or run windows from virtual machine, if you don't want to infest computer with AC (even tho, AC uninstaller does it's job well in my experience)

@Sontarr
Copy link

Sontarr commented Jan 20, 2024

Edit: It doesn't work, pressing it only gives 'Multi Mode' no 'Single Mode'

Chance you have HDR enabled? With HDR on the screen always works in multizone. Singlezone is only available if HDR is off.

@seerge
Copy link
Owner

seerge commented Jan 20, 2024

@xSimone thanks, you did Method 1, and I need Method 2. Can you upload that ?

Asus Endpoint responsible for Miniled toggle is 5001E,
https:/seerge/g-helper/blob/ce0a1c0ed2529271dff93554151c78dddefc11bb/app/AsusACPI.cs#L76C39-L76C49

And in your scan i see them starting form

60024 : 8c308086 (2351988870)                                                                                           
60095 : 1 (1)                                                                                                           

So you clearly don't have that available, at least in a way it's done on all other miniled devices.

@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

I will try method two. I am installing windows right now though one moment ;x

@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

So on Scar 2024 model, there's THREE modes.

image image image

Using Armoury Crate sadly. :c

@seerge
Copy link
Owner

seerge commented Jan 20, 2024

@xSimone is it for new windows install ? If so - can you check if button is available in G-Helper on it?

If not - please submit a dump using Method 2 (as I was asking)

@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

It do not show on G-Helper, it is stock install, I will try method 2, thank you!

@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

bgrt.zip

I hope this is help. :<

@seerge
Copy link
Owner

seerge commented Jan 20, 2024

@xSimone great, I have found a miniled toggle for your device :) it's 0x0005002E

Please try this build, and post a log from it
GHelper.zip

@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

IT WORK! I love you. :3

@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

log.txt

@seerge
Copy link
Owner

seerge commented Jan 20, 2024

@xSimone Do all 3 statuses work ? Can you post a screenshot of how each one looks (it could be handy for a feature announcement)

New stratus (Multizone Strong) should have blue border around.

@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

Yes they all work, but I think Multizone and Multizone Strong are back to front.

Edit

They all must switch.

Multizone Strong = One Zone
Multizone = Multizone Strong
One Zone = Multizone

So names are just need to slide across. ;d But works!

@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

image

@seerge
Copy link
Owner

seerge commented Jan 20, 2024

@xSimone ok, can you check this build and see if they are named correctly now ?

GHelper.zip

@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

Yaaay! :3
Fix ;d <3

@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

Maybe rename the 'off' / 'Multizone without border' to 'Singlezone' or 'Onezone'

@seerge
Copy link
Owner

seerge commented Jan 20, 2024

@xSimone, try this build

GHelper.zip

Can you double check if all 3 modes are displayed / named correctly ?

Single Zone - should have no border
Multi Zone - blue border
Multi Zone Strong - red border

(also try to restart app and see if after that it still shows correctly)

After that

Can you turn on HDR in windows settings, and open app again - in HDR mode, switch should be disabled but say Multi Zone with Blue border

@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

Yaaay! :3

Setting is remember!

I test HDR now.

@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

HDR work! Switch is disable.
But I'm think Switch should be stuck on Multi Zone Strong

Edit: Oh, it just freeze button no matter what, or at least will change to 'Multi Zone' if is not on 'Multi Zone Strong' but then is freeze.

This is fine? ;x

@seerge
Copy link
Owner

seerge commented Jan 20, 2024

@xSimone in HDR yo can't turn Multizone Off (by definition), so whole button is disabled (as I told above). This is fine.

I assume this is completed then, thanks for testing :)

@seerge seerge closed this as completed Jan 20, 2024
@xSimone
Copy link
Author

xSimone commented Jan 20, 2024

Yaaaay :3

Blue-Heart-Emoji-Meaning

@seerge
Copy link
Owner

seerge commented Apr 30, 2024

@xSimone hello,

Other user on reddit says that labels are swapped for this switch

https://www.reddit.com/r/ASUSROG/s/SUO3evD7J5

My idea is that label should reflect currently active multizone state

Do you know what is different between your observations and theirs?

@seerge
Copy link
Owner

seerge commented Apr 30, 2024

@xSimone i think I know from where the difference is coming from

You wanted to label buttons bases on NEXT state, not current. From my point of view its better to label actual state instead

This build should do that

GHelper.zip

@xSimone
Copy link
Author

xSimone commented Apr 30, 2024

Owh not, I'm wanted CURRENT state, not next.. I'm happy with how is work.

Maybe his specific model laptop profile with G-Helper is wrong order?

image

I'm currently use Multi Strong, and is say Multi Strong.

@seerge
Copy link
Owner

seerge commented Apr 30, 2024

@xSimone this build should correct labels for G16, but keep them same for G18

GHelper.zip

seerge added a commit that referenced this issue May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants