Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Not now"/"Remind me later" button to update dialog and rename "No" to "Skip version" #3208

Open
2 tasks done
tonweg15 opened this issue Oct 3, 2024 · 7 comments
Open
2 tasks done
Labels
question Further information is requested

Comments

@tonweg15
Copy link

tonweg15 commented Oct 3, 2024

Rules

  • I made myself familiar with the Readme, FAQ and Troubleshooting.
  • I understand that, if insufficient information will be provided, my issue will be closed without an answer.

Is your feature request related to a problem? Please describe

Sometimes, when I start G-Helper, there is an update available, but even though the update process is really fast, I don't want to update right now for one reason or another, but I still might want to update later and not skip the update altogether. But when I then click on No, a skip_version entry is added to the config file and on subsequent starts, the update dialog is therefore no longer displayed.

Describe the solution you'd like

Instead of there only being a Yes and No option (which is also kinda misleading, since it doesn't only not update, it also skips that version altogether), there would be Yes, Skip version and Not now or Remind me later. The behaviour for Yes and Skip version would be unchanged, Not now or Remind me later would simply close the windows and not update or add anything to the config file.

Describe alternatives you've considered

  • manually download the latest release and replace the current executable (this doesn't preserve admin permissions)
  • quit G-Helper, remove the skip_version entry in the config file, start G-Helper

Device and Model

Flow X13 2022 GV301RE, XG Mobile 6850XT

Additional information.

No response

@seerge
Copy link
Owner

seerge commented Oct 3, 2024

@tonweg15 hello.

I can add that, but i'm not sure if it's worth to overcomplicate process here.

What are the downsides of updating straight away ? It's an (almost) instant process. App just downloads zip with new version from github, and unpacks it over old one.

Also manually replacing old exe with new one does not affect any admin permissions. Startup task pointing to exe remains same, and if was running app as admin on logon before - it will keep doing that.

@seerge seerge added the question Further information is requested label Oct 3, 2024
@seerge
Copy link
Owner

seerge commented Oct 6, 2024

@tonweg15 any updates here ? :)

@moritzbeck13
Copy link

Sorry, posted this with the wrong account.

What are the downsides of updating straight away ? It's an (almost) instant process. App just downloads zip with new version from github, and unpacks it over old one.

I like to read the release notes first, which generally is a good practice when updating i think.
Also sometimes when I just really need to grab my laptop in a hurry and change mode or something, I mentally just don't have time for it.
It might be a little more complicated, but I think one should at least be able to update at a later point without jumping through some extra hoops.

Also manually replacing old exe with new one does not affect any admin permissions. Startup task pointing to exe remains same, and if was running app as admin on logon before - it will keep doing that.

No clue if that is an error on my side then, but whenever I replace the executable, I have to uncheck and recheck Run on startup, where I then get the User Account Control dialog, in order to get it to work again.

@seerge
Copy link
Owner

seerge commented Oct 6, 2024

@moritzbeck13

What I can do (to keep things simple), is instead of remembering No forever for each specific version - remember it for some period of time (for example 3 days) and then ask again.

In my opinion, there is no reason to not to update. As all updates are incremental, and it's always good to use latest release.

@moritzbeck13
Copy link

I would be fine with getting asked to update every time I start G-Helper more than the current solution. So in my opinion, you could remove the skip_version altogether. Would probably be simpler to implement aswell.

@seerge
Copy link
Owner

seerge commented Oct 6, 2024

@moritzbeck13 that may be too annoying for some people actually (the whole reason why i remember the choice in a first place)

Alternatively I can just run auto-update process when you click on the version link ... but from the other side, I like how it opens releases page now to read all release notes.

@moritzbeck13
Copy link

Alternatively I can just run auto-update process when you click on the version link ... but from the other side, I like how it opens releases page now to read all release notes.

Same actually.
What if you include G-Helper in the updates menu and make the Updates button red or something like that when an update is available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants