Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository redirect breaks asset page? #309

Open
ccressent opened this issue Feb 18, 2020 · 3 comments
Open

Repository redirect breaks asset page? #309

ccressent opened this issue Feb 18, 2020 · 3 comments

Comments

@ccressent
Copy link

This page is stuck "Scanning your asset...". We recently renamed the associated repo from sensu/sensu-aws-ec2-deregistration-handler to sensu/sensu-ec2-handler and the old repo URL is a redirect to the new repo URL.

Could it be the cause of the breakage?

@pzupan
Copy link

pzupan commented Feb 18, 2020

It looks like there is a compilation error. One of the release assets is missing.

@ccressent
Copy link
Author

It looks like it got out of that "Scanning your asset..." state after a while and indeed now it's showing a "compilation" error. The asset is not really missing; the repository has changed name and the assets are now named differently. See the plugin's release page.

The issue seems to be that while Bonsai follows the redirect to the new repo, it keeps using the old name to construct what the .tar.gz file names ought to be. This is not incorrect per se, the asset name on Bonsai is still sensu/sensu-aws-ec2-deregistration-handler after all, but this is an unforeseen consequence of renaming repositories on Github and it will need to be fixed/handled one way or another.

The Bonsai configuration suggests that #{repo} should be the new repo name though?

- arch: amd64
  filter:
  - entity.system.os == 'linux'
  - entity.system.arch == 'amd64'
  platform: linux
  sha_filename: "#{repo}_#{version}_sha512-checksums.txt"
  asset_filename: "#{repo}_#{version}_linux_amd64.tar.gz"

I haven't though of the best solution for this; I'm just raising this as an issue.

@ccressent
Copy link
Author

Also, as of right now, the README's markdown is not rendering properly on Bonsai. See on Bonsai vs on Github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants