Expanded file date options and added Cover art scanning #181
Conversation
Add created at
* fix(subsonic): route settings.view -> admin home * unfunny the comments * refactor(scanner): follow symlinks, move context, update mockfs related sentriz#174 * fix: add stub getStarred views to shut up refix Co-authored-by: sentriz <[email protected]>
|
Hi and thanks. I'm not sure what the benefit of scanning only covers is. Is it a performance thing? It seems to me like a lot of added complexity |
|
The idea of the cover scan was indeed performance related and to address the first point @bobberb made in their issue (#135). While it does add complexity to the code base, it is significantly faster than doing a full scan (seconds as opposed to minutes). If the added complexity is too much, I can redo the PR to just include the additional date options. |
|
Thanks for the context on cover scanning. Personally on my system a quick scan takes about 15s on 50k tracks and will pick up any new or changed covers. May I ask with your system, how many tracks? And where is the db file stored? Spinny disk or SSD? Also, is the music mounted locally, or a remote mount? Cheers |
|
I have pulled and built this PR multiple times over the last 4 hours. Since I opened issue #135, unfortunately, airsonic already failed and was forked by another team. It still remains a very well-running docker image, albeit one that soaks up 2GB RAM at idle while your nice goland gonic does not. I have been unable to fully commit to Gonic because moving and touching those files in the folder of an album could have reset its position in Recently Added. I speak as a migrant from Airsonic, I much prefer having a stable "Recently Added" list, especially one that can tolerate album art changes. Current PR allows me to drop in album art without changing album order in that list. I've been running both your code and Airsonic side by side for a good while now. I much prefer gonic for speed and memory cost however my mind is still oriented to "Recently Added = Recently Downloaded order". I agree with @b-levin that it should be based on a number given by the filesystem - not gonic. @b-levin thank you! |
|
I should note that at the current time, this branch does not currently respect albums which are present prior to gonic. 1st import will be random order seemingly. Every album dropped in thereafter is accepted in a list which is immune from movement by album art updates. |
I got 7s for both scans - I'm myself more excited for a stable list on this branch. |
|
I was predominately leaning on @bobberb for performance testing, as my library is too small to have a real difference in testing. The more stable list is the highlight of these changes. I'm only working with a few hundred tracks on locally mounted SSD storage, plus when combined with the fact I've been testing these changes on my desktop results in both cover and quick scans to take only a second or two at the most. Given the fact that the cover scan seems to be a bit redundant, would the best approach be to remove it from this PR and keep the additional date? |
|
howdy and sorry for the delay yeah @b-levin I think we could remove the cover scanning feature for now - then it will be easy for me to review the changes around ctime/mtime after that, we could have a look at cover scanning again as you suggest, or else see if the scanner performance could be improved in the case of only covers changing. a bit more easy for the user thanks! |
|
@sentriz Not a problem, this can definitely be a busy time of year! Given that the cover scan feature is getting split out, I'm going to close this PR and open and open a new one just with the time changes. |
For Issue #135
Expanded the date parameters stored in the
Albumstruct to includeCreatedAt(in addition toModifiedAt). Additionally, users can now use thecreate-sortoption in the file config or command line flag to change which date (CreatedAtorModifiedAt) is used for the sorting in theServeHomefunction.The ability to just scan for album cover art changes was added to mirror the feature from airsonic. Users can manually trigger the cover art scan from the homepage by clicking on the new
cover scanbutton under recent folders on the admin/home page. Additionally, a ticker was added for the new cover art scan, which is disabled by default and can be modified via either thecover-scan-intervalin the config file or command line flag.