Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto_fill_txn #76

Closed
wants to merge 21 commits into from
Closed

Add auto_fill_txn #76

wants to merge 21 commits into from

Conversation

LimpidCrypto
Copy link
Collaborator

@LimpidCrypto LimpidCrypto commented Apr 15, 2024

High Level Overview of Change

Adds transaction auto filling feature. Transactions have fields that can be filled automatically. This PR is required for #71

Context of Change

Type of Change

  • New feature (non-breaking change which adds functionality)

TODO

  • fix mutable borrow issues
  • add testing
  • handle unwraps

@LimpidCrypto LimpidCrypto self-assigned this Apr 15, 2024
@LimpidCrypto LimpidCrypto changed the base branch from main to dev April 15, 2024 15:06
@LimpidCrypto LimpidCrypto mentioned this pull request Jun 9, 2024
2 tasks
@LimpidCrypto LimpidCrypto mentioned this pull request Jun 18, 2024
7 tasks
@LimpidCrypto LimpidCrypto added the enhancement New feature or request label Aug 10, 2024
LimpidCrypto pushed a commit that referenced this pull request Aug 10, 2024
@LimpidCrypto LimpidCrypto mentioned this pull request Aug 10, 2024
4 tasks
@LimpidCrypto
Copy link
Collaborator Author

Replaced by #80

LimpidCrypto added a commit that referenced this pull request Aug 10, 2024
LimpidCrypto added a commit that referenced this pull request Aug 13, 2024
LimpidCrypto added a commit that referenced this pull request Aug 31, 2024
* move BinarySerializer and BinaryParser

* add STObject

* current state of txn signing

* current state of sign

* current state of sign

* use String instead of Cow<'a, str> for structs using serde_with_tag macro due to lifetime issues when deserializing

* utilize Cow for models

* utilize Cow for models

* cargo fmt

* add simple test

* add devcontainer

* fix async client tests

* fix github workflow

* fix tests with --all-features

* fix --no-default-features tests with embedded-ws

* try fix colliding embebedded-websocket feature with dep: syntax

* fix ambiguous name error

* Revise Models (#74)

* current state

* initial

* initial

* add to changelog

* impl LedgerObject trait

* remove .DS_Store

* add documentation

* cargo fix

* add Default trait to FlagCollection

* refactoring of models

* fix serde tests

* fix serde tests

* Delete src/models/.DS_Store

* remove dafault_none

* resolve comments

* revise dependencies

* remove old clients

* add new clients

* add codec for std embedded websocket

* move websocket exceptions

* add WebsocketBase

* add Client and AsyncClient traits

* add XRPLWebsocketIO as standardized trait

* adjust clients mod

* add XRPLResponse

* revise the Request trait to have methods to get a resut models common fields

* cargo fmt

* add get_random_id utility function

* add xrpl testnet uri

* revise the tests to work with the changes

* error handling

* improve testing

* implement websocket client request

* implement websocket client request for embedded websocket

* update rand trying to get rid of cargo check: OsRng: rand_core::RngCore is not satisfied error

* fix github workflow build and tests

* fix github workflow build and tests

* run linters

* add json rpc client

* add json rpc for std and tests

* cargo fmt

* add pre-commit test with json-rpc-std

* cargo fmt

* cargo fix

* improve client code

* refactor features

* fix tungstenite example

* fix clients

* fix client tests

* fix tests

* rename features in github workflow

* add transaction auto filling as in #76 (#80)

* current state of txn signing

* current state of sign

* current state of sign

* add simple test

* resolve errors caused by updating branch

* resolve errors caused by updating branch

* add autofill_and_sign

* make tx signing work

* improve sign test

* handle unwraps

* add autofill_and_sign

* add sign and submit

* fix errors caused by solving merge conflicts

* rename SerializedDict and SerializedList to STObject and STArray

* rename SerializedDict and SerializedList to STObject and STArray

* handle unwraps

* fix tests

* fix tests

* fix tests

* add multisigning

* add multisigning

* fix tests

* fix tests

---------

Co-authored-by: LimpidCrypto <[email protected]>
LimpidCrypto added a commit that referenced this pull request Aug 31, 2024
* move BinarySerializer and BinaryParser

* add STObject

* current state of txn signing

* current state of sign

* current state of sign

* use String instead of Cow<'a, str> for structs using serde_with_tag macro due to lifetime issues when deserializing

* utilize Cow for models

* utilize Cow for models

* cargo fmt

* add simple test

* add devcontainer

* fix async client tests

* fix github workflow

* fix tests with --all-features

* fix --no-default-features tests with embedded-ws

* try fix colliding embebedded-websocket feature with dep: syntax

* fix ambiguous name error

* Revise Models (#74)

* current state

* initial

* initial

* add to changelog

* impl LedgerObject trait

* remove .DS_Store

* add documentation

* cargo fix

* add Default trait to FlagCollection

* refactoring of models

* fix serde tests

* fix serde tests

* Delete src/models/.DS_Store

* remove dafault_none

* resolve comments

* revise dependencies

* remove old clients

* add new clients

* add codec for std embedded websocket

* move websocket exceptions

* add WebsocketBase

* add Client and AsyncClient traits

* add XRPLWebsocketIO as standardized trait

* adjust clients mod

* add XRPLResponse

* revise the Request trait to have methods to get a resut models common fields

* cargo fmt

* add get_random_id utility function

* add xrpl testnet uri

* revise the tests to work with the changes

* error handling

* improve testing

* implement websocket client request

* implement websocket client request for embedded websocket

* update rand trying to get rid of cargo check: OsRng: rand_core::RngCore is not satisfied error

* fix github workflow build and tests

* fix github workflow build and tests

* run linters

* add json rpc client

* add json rpc for std and tests

* cargo fmt

* add pre-commit test with json-rpc-std

* cargo fmt

* cargo fix

* improve client code

* refactor features

* fix tungstenite example

* fix clients

* fix client tests

* fix tests

* rename features in github workflow

* add transaction auto filling as in #76 (#80)

* current state of txn signing

* current state of sign

* current state of sign

* add simple test

* resolve errors caused by updating branch

* resolve errors caused by updating branch

* add autofill_and_sign

* make tx signing work

* improve sign test

* handle unwraps

* add autofill_and_sign

* add sign and submit

* fix errors caused by solving merge conflicts

* rename SerializedDict and SerializedList to STObject and STArray

* rename SerializedDict and SerializedList to STObject and STArray

* handle unwraps

* fix tests

* fix tests

* fix tests

* add multisigning

* add multisigning

* fix tests

* fix tests

---------

Co-authored-by: LimpidCrypto <[email protected]>
@LimpidCrypto LimpidCrypto deleted the auto-fill-txn branch September 8, 2024 18:19
LimpidCrypto added a commit that referenced this pull request Oct 6, 2024
LimpidCrypto added a commit that referenced this pull request Oct 6, 2024
* move BinarySerializer and BinaryParser

* add STObject

* current state of txn signing

* current state of sign

* current state of sign

* use String instead of Cow<'a, str> for structs using serde_with_tag macro due to lifetime issues when deserializing

* utilize Cow for models

* utilize Cow for models

* cargo fmt

* add simple test

* add devcontainer

* fix async client tests

* fix github workflow

* fix tests with --all-features

* fix --no-default-features tests with embedded-ws

* try fix colliding embebedded-websocket feature with dep: syntax

* fix ambiguous name error

* Revise Models (#74)

* current state

* initial

* initial

* add to changelog

* impl LedgerObject trait

* remove .DS_Store

* add documentation

* cargo fix

* add Default trait to FlagCollection

* refactoring of models

* fix serde tests

* fix serde tests

* Delete src/models/.DS_Store

* remove dafault_none

* resolve comments

* revise dependencies

* remove old clients

* add new clients

* add codec for std embedded websocket

* move websocket exceptions

* add WebsocketBase

* add Client and AsyncClient traits

* add XRPLWebsocketIO as standardized trait

* adjust clients mod

* add XRPLResponse

* revise the Request trait to have methods to get a resut models common fields

* cargo fmt

* add get_random_id utility function

* add xrpl testnet uri

* revise the tests to work with the changes

* error handling

* improve testing

* implement websocket client request

* implement websocket client request for embedded websocket

* update rand trying to get rid of cargo check: OsRng: rand_core::RngCore is not satisfied error

* fix github workflow build and tests

* fix github workflow build and tests

* run linters

* add json rpc client

* add json rpc for std and tests

* cargo fmt

* add pre-commit test with json-rpc-std

* cargo fmt

* cargo fix

* improve client code

* refactor features

* fix tungstenite example

* fix clients

* fix client tests

* fix tests

* rename features in github workflow

* add transaction auto filling as in #76 (#80)

* current state of txn signing

* current state of sign

* current state of sign

* add simple test

* resolve errors caused by updating branch

* resolve errors caused by updating branch

* add autofill_and_sign

* make tx signing work

* improve sign test

* handle unwraps

* add autofill_and_sign

* add sign and submit

* fix errors caused by solving merge conflicts

* rename SerializedDict and SerializedList to STObject and STArray

* rename SerializedDict and SerializedList to STObject and STArray

* handle unwraps

* fix tests

* fix tests

* fix tests

* add multisigning

* add multisigning

* fix tests

* fix tests

---------

Co-authored-by: LimpidCrypto <[email protected]>
LimpidCrypto added a commit that referenced this pull request Oct 6, 2024
LimpidCrypto added a commit that referenced this pull request Oct 6, 2024
* move BinarySerializer and BinaryParser

* add STObject

* current state of txn signing

* current state of sign

* current state of sign

* use String instead of Cow<'a, str> for structs using serde_with_tag macro due to lifetime issues when deserializing

* utilize Cow for models

* utilize Cow for models

* cargo fmt

* add simple test

* add devcontainer

* fix async client tests

* fix github workflow

* fix tests with --all-features

* fix --no-default-features tests with embedded-ws

* try fix colliding embebedded-websocket feature with dep: syntax

* fix ambiguous name error

* Revise Models (#74)

* current state

* initial

* initial

* add to changelog

* impl LedgerObject trait

* remove .DS_Store

* add documentation

* cargo fix

* add Default trait to FlagCollection

* refactoring of models

* fix serde tests

* fix serde tests

* Delete src/models/.DS_Store

* remove dafault_none

* resolve comments

* revise dependencies

* remove old clients

* add new clients

* add codec for std embedded websocket

* move websocket exceptions

* add WebsocketBase

* add Client and AsyncClient traits

* add XRPLWebsocketIO as standardized trait

* adjust clients mod

* add XRPLResponse

* revise the Request trait to have methods to get a resut models common fields

* cargo fmt

* add get_random_id utility function

* add xrpl testnet uri

* revise the tests to work with the changes

* error handling

* improve testing

* implement websocket client request

* implement websocket client request for embedded websocket

* update rand trying to get rid of cargo check: OsRng: rand_core::RngCore is not satisfied error

* fix github workflow build and tests

* fix github workflow build and tests

* run linters

* add json rpc client

* add json rpc for std and tests

* cargo fmt

* add pre-commit test with json-rpc-std

* cargo fmt

* cargo fix

* improve client code

* refactor features

* fix tungstenite example

* fix clients

* fix client tests

* fix tests

* rename features in github workflow

* add transaction auto filling as in #76 (#80)

* current state of txn signing

* current state of sign

* current state of sign

* add simple test

* resolve errors caused by updating branch

* resolve errors caused by updating branch

* add autofill_and_sign

* make tx signing work

* improve sign test

* handle unwraps

* add autofill_and_sign

* add sign and submit

* fix errors caused by solving merge conflicts

* rename SerializedDict and SerializedList to STObject and STArray

* rename SerializedDict and SerializedList to STObject and STArray

* handle unwraps

* fix tests

* fix tests

* fix tests

* add multisigning

* add multisigning

* fix tests

* fix tests

---------

Co-authored-by: LimpidCrypto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

1 participant