Add Safety comments to unsafe blocks #2319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some small tweaks to the unsafe blocks to make them easier to audit:
serde::de::Format::Buf
to be a private type since it's already not publicly exposed.Buf::as_str()
to be unsafe, since it relies on the caller to only write UTF-8 into the buffer.// Safety: ...
comments to the two callsites inde::Visitor
that usesBuf
to write an error message withi128
andu128
types.// Safety: ...
comment.