Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'type-operators' dependency #174

Closed
chshersh opened this issue May 31, 2018 · 1 comment · Fixed by #184
Closed

Remove 'type-operators' dependency #174

chshersh opened this issue May 31, 2018 · 1 comment · Fixed by #184
Labels
mistake reexport type:fix Code is modified, but without breaking changes or new definitions. Not necessary a bug fix.

Comments

@chshersh
Copy link
Contributor

After gathering move feedback on universum usage we discovered that people don't actually use type operators. They can complicate code written with the help of universum, they can break some IDE tools. So it was proposed to remove type-ops dependency.

Maybe we can keep at least $ type operator, but write it manually?
@gromakovsky
Copy link
Member

I propose to do it in two steps: remove this dependency but keep all exports in 1.3.0 (copy-paste operators from type-operators) and then later decide whether type operators should be in Universum at all (as a separate issue probably).

rockbmb added a commit to rockbmb/universum that referenced this issue Jul 23, 2018
@rockbmb
[serokell#174] Remove 'type-operators' dependency
9681cda
rockbmb added a commit to rockbmb/universum that referenced this issue Jul 23, 2018
@rockbmb
[serokell#174] Remove 'type-operators' dependency
f7b68c5
@rockbmb rockbmb mentioned this issue Jul 23, 2018
Merged
rockbmb added a commit to rockbmb/universum that referenced this issue Jul 23, 2018
@rockbmb
[serokell#174] Remove 'type-operators' dependency
fec2a72
rockbmb added a commit to rockbmb/universum that referenced this issue Jul 23, 2018
@rockbmb
[serokell#174] Remove 'type-operators' dependency
ca97f0c
@gromakovsky gromakovsky added this to the v1.3.0: Reduction milestone Aug 6, 2018
@gromakovsky gromakovsky added the type:fix Code is modified, but without breaking changes or new definitions. Not necessary a bug fix. label Aug 6, 2018
rockbmb added a commit to rockbmb/universum that referenced this issue Aug 7, 2018
@rockbmb
[serokell#174] Remove 'type-operators' dependency
b53b190
@gromakovsky gromakovsky removed this from the v1.3.0: Reduction milestone Aug 7, 2018
rockbmb added a commit to rockbmb/universum that referenced this issue Aug 7, 2018
@rockbmb
[serokell#174] Remove 'type-operators' dependency
e736db5
rockbmb added a commit to rockbmb/universum that referenced this issue Aug 8, 2018
@rockbmb
[serokell#174] Remove 'type-operators' dependency
ffe3c50
rockbmb added a commit to rockbmb/universum that referenced this issue Aug 8, 2018
@rockbmb
[serokell#174] Remove 'type-operators' dependency
0343096
rockbmb added a commit to rockbmb/universum that referenced this issue Aug 8, 2018
@rockbmb
[serokell#174] Remove 'type-operators' dependency
d690f5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mistake reexport type:fix Code is modified, but without breaking changes or new definitions. Not necessary a bug fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Some fixes for 1.3.0 rockbmb/universum
2 participants
@gromakovsky @chshersh