Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export exceptions-related functions from safe-exceptions #62

Closed
gromakovsky opened this issue Aug 29, 2017 · 1 comment
Closed

Export exceptions-related functions from safe-exceptions #62

gromakovsky opened this issue Aug 29, 2017 · 1 comment
Labels
feature request have to think

Comments

@gromakovsky
Copy link
Member

Universum exports some functions from Control.Monad.Catch, e. g.: catch, catchAll, throwM. This function don't work well with async exceptions.
You can read about safe-exceptions package here: https:/fpco/safe-exceptions#readme
I propose to export those version of functions.
One caveat is that if we want to define our own implementation of e. g. catch (which is part of MonadCatch), then we need import different thing. But it should be very rare case, so I think it's ok.
@gromakovsky gromakovsky mentioned this issue Aug 29, 2017
Merged
@gromakovsky
Copy link
Member Author

Made a PR #63.

gromakovsky added a commit that referenced this issue Aug 30, 2017
@gromakovsky
Merge pull request #63 from serokell/gromak/#62-safe-exceptions
d8f99f2 
Export exceptions-related functions from safe-exceptions
@chshersh chshersh closed this as completed Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request have to think
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gromakovsky @chshersh