[SRK-119] Update .hlint.yaml to version used in Ariadne #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
gromakovsky
reviewed
Jan 14, 2019
| @@ -1,17 +1,13 @@ | |||
| - arguments: | |||
| - -XTypeApplications # TypeApplications are disabled by default in HLint, | |||
| # although the documentation says otherwise | |||
There was a problem hiding this comment.
I haven't checked, but IMO it doesn't matter, as the hlint config for Universum users is no place for custom extensions.
gromakovsky
approved these changes
Jan 17, 2019
|
@volhovm I need a second approval for merging. |
volhovm
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-XTypeApplicationsflipfoldl'<<$>>Related issues(s)
https://issues.serokell.io/issue/SRK-119
This PR moves the updated Universum rules from the
serokell-utilrepository to theuniversumrepository, where they are easier to maintain.✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
are inextricably linked. Otherwise I should open multiple PR's.
reference this issue. See also auto linking on
github.
Related changes (conditional)
Tests
silently reappearing again.
Documentation
I checked whether I should update the docs and did so if necessary:
Record your changes
and
Stylistic guide (mandatory)
My commit history is clean (only contains changes relating to my
issue/pull request and no reverted-my-earlier-commit changes) and commit
messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit descriptionIf necessary both of these can be achieved even after the commits have been
made/pushed using rebase and squash.