Fix documentation in Universum.Lifted.File to mention correct module #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks. We should merge #216 first to make CI pass here, then you'll have to rebase on latest master. |
serhiip
added a commit
to serhiip/universum
that referenced
this pull request
Jul 26, 2019
|
As #216 is merged I've rebased this one |
gromakovsky
approved these changes
Jul 26, 2019
gromakovsky
reviewed
Jul 27, 2019
CHANGES.md
Outdated
| @@ -6,12 +6,16 @@ Unreleased | |||
| from the list of changes suggested in `.hlint.yaml`. | |||
| * [#214](https:/serokell/universum/issues/214): | |||
| Update supported GHC versions (replace 7.10.3 with 8.6.5). | |||
|
|
|||
There was a problem hiding this comment.
Looks like redundant space.
|
Can you please make history linear here? |
serhiip
added a commit
to serhiip/universum
that referenced
this pull request
Jul 27, 2019
serhiip
added a commit
to serhiip/universum
that referenced
this pull request
Jul 27, 2019
|
Rebased everything onto master |
goodsoft
approved these changes
Jul 30, 2019
|
Oh, and now the only remaining obstacle is this:
|
Heimdell
approved these changes
Jul 30, 2019
|
Oh c'mon |
rockbmb
approved these changes
Aug 1, 2019
|
Thanks for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a typo in referenced module names - there is no file related functions in
Data.Text(correct module isData.Text.IO). This PR fixes the issue.Issue could be observed here http://hackage.haskell.org/package/universum-1.5.0/docs/Universum-Lifted-File.html
✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
are inextricably linked. Otherwise I should open multiple PR's.
reference this issue. See also auto linking on
github.
Related changes (conditional)
Record your changes
and
Stylistic guide (mandatory)
issue/pull request and no reverted-my-earlier-commit changes) and commit
messages start with identifiers of related issues in square brackets.